Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cmake preset simple prefix #13015

Merged

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jan 31, 2023

Changelog: Feature: Implement customizable CMakeToolchain.presets_prefix so presets name prepend this.
Changelog: Fix: Define CMakeToolchain.presets_prefix="conan" by default, to avoid conflict with other users presets.
Docs: https://github.com/conan-io/docs/pull/XXXX

Note this could be breaking some users that call cmake --presets xxxx directly or in their CI.

@memsharded memsharded modified the milestones: 2.0.0-beta9, 1.59 Jan 31, 2023
@SSE4
Copy link
Contributor

SSE4 commented Feb 1, 2023

it doesn't set --prefix argument for the CMake, so naming is kinda confusing...

@memsharded memsharded changed the base branch from develop to develop2 February 9, 2023 15:56
@memsharded memsharded modified the milestones: 1.59, 2.0.0-beta10 Feb 9, 2023
@memsharded memsharded marked this pull request as ready for review February 9, 2023 15:59
@memsharded memsharded assigned memsharded and unassigned czoido Feb 9, 2023
@memsharded memsharded merged commit 14ed84c into conan-io:develop2 Feb 9, 2023
@memsharded memsharded deleted the feature/cmake_preset_simple_prefix branch February 9, 2023 17:41
@prince-chrismc
Copy link
Contributor

@memsharded is this a duplicate of #12932 🤔

@memsharded
Copy link
Member Author

It is partially #12932, but #12932 contains more changes. We have decided to move it to 2.0, so #12932 remainder after rebasing will be probably 2.0 too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants