Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop2] add pkg name in new cache path hashes #13011

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jan 30, 2023

Changelog: Feature: Add package names in Conan cache hash paths.

Today I have missed hints in paths while debugging...

I am trying this approach:

  • Reducing the hash length in 3 characters 16=>13
  • Adding first 5 characters of package name => total unique identifier = 13+5 = 18
  • Given that package names are also distinct, the entropy should be equal, or even better
  • The 2 extra characters in length, can be removed from the identifier "tmp" used for temporal builds "tmp"->"t". Given that packages store is just "p", I don't think this will worsen debuggability. So the total path length remains the same.

(also removing some closedb code, apparently dead)

Close #12952

@memsharded memsharded added this to the 2.0.0-beta9 milestone Jan 30, 2023
@memsharded memsharded marked this pull request as ready for review January 30, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants