Fix fail in packages parallel download due to database concurrency issues #12930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czoido
changed the title
memsharded
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Fix fail in parallel packages download due to database concurrency issues.
Docs: omit
Downloading packages in paralell was failing, the test test_basic_parallel_install that covered it was forcing the number of threads to 1 waiting for the implementation of some mutex mechanism in the cache. This PR fixes the issue with the most simple solution that is opening a new database connection for each query. The usage of the database in Conan is not so intensive compared with other operations and some preliminar performance tests seems to indicate that it's not affecting performance so much. Let's try this and if we have performance problems use another way of solving the db concurrency issues.