[dev2][conan list] Enhancements 2.0 #12801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franramirez688
commented
Dec 28, 2022
| cli_out_write(f"{indentation * 4}Empty package information", | ||
| for ref_name, refs in info_per_ref_name.items(): | ||
| cli_out_write(f"{indentation}{ref_name}", fg=recipe_name_color) | ||
| for ref, prefs in refs.items(): |
There was a problem hiding this comment.
From here to below, there are no changes at all. It's only the indentation diff.
memsharded
reviewed
Dec 28, 2022
| @@ -114,7 +114,7 @@ def list(conan_api: ConanAPI, parser, *args): | |||
| results[name] = {"error": str(e)} | |||
| else: | |||
| results[name] = list_bundle.serialize() if args.format in ("json", "html") \ | |||
| else list_bundle.recipes | |||
| else list_bundle.ordered_recipes_by_name | |||
There was a problem hiding this comment.
I think it is better to leave the list_bundle.recipes and have that method/property to return the references ordered?
| output = str(self.client.out) | ||
| expected_output = textwrap.dedent("""\ | ||
| Local Cache: | ||
| test_recipe |
There was a problem hiding this comment.
Were you ordering recipes by name? pkg should be before test_recipe?
| self.recipes.setdefault(pref.ref, []).append((pref, binary_info)) | ||
|
|
||
| @property | ||
| def ordered_recipes_by_name(self): | ||
| ret = OrderedDict() |
There was a problem hiding this comment.
This is not a SortedDict, the OrderedDict is ordered by insertion order, so I think this is not really sorting anything?
czoido
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Ordering if same ref.name but different versions.
Changelog: Feature: Avoid requesting package configuration if PkgID is passed.
Docs: omit
Related to #12798