Make ConanOutput write methods chainable #12780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
commented
Dec 23, 2022
|
|
||
| def rewrite_line(self, line): | ||
| tmp_color = self._color | ||
| self._color = False | ||
| TOTAL_SIZE = 70 | ||
| LIMIT_SIZE = 32 # Hard coded instead of TOTAL_SIZE/2-3 that fails in Py3 float division | ||
| LIMIT_SIZE = TOTAL_SIZE // 2 - 3 |
There was a problem hiding this comment.
The old comment complained about Py3 division being float by default. Using the built-in int division fixes the issue (//)
memsharded
approved these changes
Dec 27, 2022
franramirez688
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Allow chaining of
self.outputwrite methodsDocs: omit
Allows the ConanOutput write methods to be chained, which simplifies some instances where it's used a lot, by removing the need to save it to a variable or initialize the object for every line