-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev2][command-list] Refactor #12756
[dev2][command-list] Refactor #12756
Conversation
Some some comments of preliminar tests with the branch (I have only and imaginary
Shouldn't it say that this package is in the local cache?
Also with this does not say where those package are and I the In my local cache I have one package id for zlib/1.2.18 but not package id's in conancenter but we don't output some message like there are no binaries in the remote or or error: local cache: good
conancenter, should we error? we output only the revision as there are no packages there:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a very good step!
It is missing some details, I think it might be incomplete for user/channel
Co-authored-by: James <memsharded@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that my review is worth much yet, but I can't see anything wrong with the changes other than what's already been pointed out (And the failing test, but I'm guessing that's for later still), nice work :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there.
Please check the pending comments, specially about conan search
.
Testing this:
Shouldn't it return the last package revision for each package id as we are adding the |
Much better the new |
* Refactoring list command * wip * Update conan/api/model.py Co-authored-by: James <memsharded@gmail.com> * wip * wip * wip * Test passing * wip * Tests OK * tests ok * Update conan/cli/commands/search.py Co-authored-by: James <memsharded@gmail.com> * wip * fixed * Fixed tests * Fixed * fix * step by step * fixed settings * Fixed Co-authored-by: James <memsharded@gmail.com>
Changelog: Feature: Refactored
conan list
and dropped all the subcommands.Docs: conan-io/docs#2874
Closes: #12651
Quick summary: