-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop2] Improve #latest
and pattern selection from remove/upload/download
#12572
[develop2] Improve #latest
and pattern selection from remove/upload/download
#12572
Conversation
#latest
from remove/upload/download#latest
and pattern selection from remove/upload/download
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 👏 My only suggestion is to change the conan/internal/api/select_pattern.py
(it seems to me it's related to the database) to something more descriptive as conan/internal/api/references_filter.py
.
Yeah, I didn't love the name, if the rest of the team also likes |
Maybe the name is not the optimal but I think it represents the purpose of the class good enough, let's merge and change the name later if we still don't like it.... |
No description provided.