Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop2] Improve #latest and pattern selection from remove/upload/download #12572

Merged
merged 12 commits into from
Nov 24, 2022

Conversation

memsharded
Copy link
Member

No description provided.

@memsharded memsharded changed the title [develop2] Remove #latest from remove/upload/download [develop2] Improve #latest and pattern selection from remove/upload/download Nov 21, 2022
@memsharded memsharded added this to the 2.0.0-beta6 milestone Nov 21, 2022
@memsharded memsharded marked this pull request as ready for review November 21, 2022 13:25
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 👏 My only suggestion is to change the conan/internal/api/select_pattern.py (it seems to me it's related to the database) to something more descriptive as conan/internal/api/references_filter.py.

@memsharded
Copy link
Member Author

Great job! 👏 My only suggestion is to change the conan/internal/api/select_pattern.py (it seems to me it's related to the database) to something more descriptive as conan/internal/api/references_filter.py.

Yeah, I didn't love the name, if the rest of the team also likes ReferenceFilter as name, I'll change it.

@czoido
Copy link
Contributor

czoido commented Nov 24, 2022

Great job! 👏 My only suggestion is to change the conan/internal/api/select_pattern.py (it seems to me it's related to the database) to something more descriptive as conan/internal/api/references_filter.py.

Yeah, I didn't love the name, if the rest of the team also likes ReferenceFilter as name, I'll change it.

Maybe the name is not the optimal but I think it represents the purpose of the class good enough, let's merge and change the name later if we still don't like it....

@czoido czoido merged commit ba9de09 into conan-io:develop2 Nov 24, 2022
@memsharded memsharded deleted the feature/develop2_remove_latest branch November 24, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants