Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[develop2] Improve cache path #12554

Merged
merged 5 commits into from
Nov 25, 2022
Merged

[develop2] Improve cache path #12554

merged 5 commits into from
Nov 25, 2022

Conversation

memsharded
Copy link
Member

Close #12549

@memsharded memsharded added this to the 2.0.0-beta6 milestone Nov 16, 2022
@memsharded memsharded marked this pull request as ready for review November 16, 2022 13:36
@czoido
Copy link
Contributor

czoido commented Nov 16, 2022

Maybe this should still work when doing conan cache path zlib/1.2.12#latest and zlib/1.2.12#pkgid#latest so that's aligned with the other commands?

@memsharded
Copy link
Member Author

Maybe this should still work when doing conan cache path zlib/1.2.12#latest and zlib/1.2.12#pkgid#latest so that's aligned with the other commands?

Which other commands? IMO, the #latest doesn't provide any value here, probably needs to be revised in the other commands?

@czoido
Copy link
Contributor

czoido commented Nov 16, 2022

Maybe this should still work when doing conan cache path zlib/1.2.12#latest and zlib/1.2.12#pkgid#latest so that's aligned with the other commands?

Which other commands? IMO, the #latest doesn't provide any value here, probably needs to be revised in the other commands?

Yes, I think that if we are removing the #latest here we should check if we should remove that in every other places like conan list, conan download and conan upload and default to the latest if not specified.

@memsharded memsharded requested a review from czoido November 24, 2022 20:47
@czoido czoido merged commit ac4daec into conan-io:develop2 Nov 25, 2022
@memsharded memsharded deleted the feature/develop2_cache_path branch November 25, 2022 10:07
@czoido czoido mentioned this pull request Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czoido czoido czoido approved these changes

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta6
Development

Successfully merging this pull request may close these issues.
2 participants
@memsharded @czoido