Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[develop2][poc] decouple test_package from create #12046

Merged
merged 9 commits into from
Sep 9, 2022
Merged

[develop2][poc] decouple test_package from create #12046

merged 9 commits into from
Sep 9, 2022

Conversation

memsharded
Copy link
Member

Lets see what breaks

@memsharded memsharded added this to the 2.0.0-beta3 milestone Sep 6, 2022
@memsharded memsharded requested review from lasote and czoido September 6, 2022 23:18
lasote
lasote reviewed Sep 7, 2022
View reviewed changes
Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not looking bad! bit complex the test-package-build and we should think about marking the build-requires in the recipe, it could be complex too.

conans/test/functional/toolchains/cmake/cmakedeps/test_apple_frameworks.py Outdated Show resolved Hide resolved
conan/cli/commands/create.py Outdated Show resolved Hide resolved
lasote
lasote approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@memsharded memsharded mentioned this pull request Sep 9, 2022
Merged
@memsharded memsharded marked this pull request as ready for review September 9, 2022 11:42
@czoido czoido merged commit 47cd3a5 into conan-io:develop2 Sep 9, 2022
@memsharded memsharded deleted the feature/decouple_test_package branch September 9, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czoido czoido czoido approved these changes

@lasote lasote lasote approved these changes

Assignees
No one assigned
Labels
type: feature
Projects
None yet
Milestone
2.0.0-beta3
Development

Successfully merging this pull request may close these issues.
3 participants
@memsharded @lasote @czoido