BUGFIX: Fail if no 'os' is specified in build profile and want to run an exte… #11728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Jul 29, 2022
| @@ -15,7 +15,6 @@ class SynchronizeTest(unittest.TestCase): | |||
|
|
|||
| def test_upload(self): | |||
| client = TestClient(servers={"default": TestServer()}, inputs=["admin", "password"]) | |||
| save(client.cache.default_profile_path, "") | |||
There was a problem hiding this comment.
Why removing this is necessary? It seems only export + upload are used here, which should never need the profile at all?
There was a problem hiding this comment.
The line 73 is doing client.run("install --requires=%s --build missing" % str(ref)) so building the package.
memsharded
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: If the 'os' is not specified in the build profile and a recipe, in Windows, wanted to run a command, it failed to prepend the build environment launcher causing a hard-to-debug command line error. Now Conan raises if the "os" is not declared in that case.
Docs: omit
Close #11727