[develop2] new pre/post_generate() and post_build_fail hooks #11593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franramirez688
approved these changes
Jul 11, 2022
lasote
reviewed
Jul 11, 2022
conans/client/generators/__init__.py
Outdated
| new_gen_folder = conanfile.generators_folder | ||
| _receive_conf(conanfile) | ||
|
|
||
| # TODO: Should this apply to the ``generate()`` method only? |
There was a problem hiding this comment.
I don't think so. I would leave it here.
lasote
approved these changes
Jul 11, 2022
czoido
approved these changes
Jul 11, 2022
memsharded
commented
Jul 11, 2022
This was referenced Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #11554 (adding a
post_build_failhook that is called when a build fail)Close #11094 (adding
pre_generateandpost_generatehook, covering the generation of files, a bit more than just thegenerate()method call)