Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop2] Let dependency define package_id modes #11441

Merged
merged 4 commits into from
Jul 26, 2022

Conversation

memsharded
Copy link
Member

No description provided.

@memsharded memsharded added this to the 2.0.0-beta1 milestone Jun 12, 2022
@memsharded memsharded requested a review from lasote June 13, 2022 08:28
Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to the code & implementation but I would wait until the feedback of the Tribe.
It could be quite messy to debug in environments like conan-center.

@memsharded
Copy link
Member Author

Agree, lets move it to beta.2 then, and wait for the feedback.

conans/model/requires.py Outdated Show resolved Hide resolved
@memsharded memsharded marked this pull request as ready for review July 26, 2022 09:01
@czoido czoido merged commit 45f283c into conan-io:develop2 Jul 26, 2022
@memsharded memsharded deleted the feature/develop2_dep_define_mode branch July 26, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants