Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] upload_policy = "skip" breaks skipping binaries? #15330

Closed
1 task
db4 opened this issue Dec 22, 2023 · 3 comments · Fixed by #15336
Closed
1 task

[question] upload_policy = "skip" breaks skipping binaries? #15330

db4 opened this issue Dec 22, 2023 · 3 comments · Fixed by #15336
Assignees
Milestone

Comments

@db4
Copy link
Contributor

db4 commented Dec 22, 2023

What is your question?

Looks like upload_policy = "skip" attribute in a non-visible dependency doesn't work as one would expect: Conan builds a binary package that should be skipped. The test case is attached. When pkg3 is built pkg1 binary should be skipped, but it's built from sources due to upload_policy = "skip" in pkg1.
test_case.zip

Have you read the CONTRIBUTING guide?

  • I've read the CONTRIBUTING guide
@memsharded memsharded self-assigned this Dec 22, 2023
@memsharded
Copy link
Member

Hi @db4

Thanks for your report.
It seems there could be a gap, or at least some undefinition in the behavior of this case. Your test case really helped to reproduce, thanks very much for putting it together.

I am checking it, seeing what possibilities of improvements are possible, I'll update here.

@memsharded
Copy link
Member

I am exploring in this draft #15336 a possible solution

db4 added a commit to db4/conan that referenced this issue Dec 25, 2023
@memsharded
Copy link
Member

Closed by #15336, it will be in next 2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants