-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the abseil/20200205 #801
Conversation
Some configurations of 'abseil/20200205' failed in build 1 (
|
@danimtb Abseil requires at least C++11. Are there any updates on how to handle this in CCI PRs? |
Some configurations of 'abseil/20200205' failed in build 2 (
|
🙂 |
we need to do something about projects requiring non-default cppstd. |
How does the C3I handle the package_id? Could it be possible to preparse it to extract the information relevant to which configurations we should do builds? We don't really have a choice but to generate additional configurations in some cases. We can't assume that it's fine to use a non-default cppstd without actually marking it in the profile. Some libraries do break the ABI on the same library version but on different standard flags - Boost and Abseil do that if I recall correctly. Other libraries could, for example, erase it in their |
Related to #54 Please comment anything there related to this topic |
cmake.install() | ||
tools.rmdir(os.path.join(self.package_folder, "lib", "cmake")) | ||
|
||
def package_info(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like it for all versions. From my experience, Abseil changes the library constantly. I would say you should create one recipe per version. However, creating one recipe version is boring, and only the cpp_info.libs will change. So, we could accept the lib list in conandata.yml, but it requires a filter there is conan-center hook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good idea! The all
folder is kinda a placeholder. Shouldn't be a problem to split recipes into different folders later on, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a big fan of the idea of having this information in the conandata.yml file, as it will be harder to read and it is mainly used (in this repo) for things related to sources. But you can always make the libs conditional to the version of the recipe if you want to keep one recipe for all of them (easier to maintain). @Minimonium in case the recipe diverges too much we can always split it to one for each version
Co-Authored-By: Uilian Ries <uilianries@gmail.com>
Some configurations of 'abseil/20200205' failed in build 3 (
|
Some configurations of 'abseil/20200205' failed in build 4 (
|
Some configurations of 'abseil/20200205' failed in build 5 (
|
Some configurations of 'abseil/20200205' failed in build 6 (
|
Some configurations of 'abseil/20200205' failed in build 7 (
|
All green in build 8 (
|
Nailed it. |
Thanks for getting this done! |
Specify library name and version: abseil/20200205
Closes #710
conan-center hook activated.