Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libfreenect2: Add new libfreenect2 package. #7628

Merged
merged 7 commits into from
Oct 20, 2021

Conversation

sh0
Copy link
Contributor

@sh0 sh0 commented Oct 10, 2021

Specify library name and version: libfreenect2/0.2.1

The libfreenect2 library is used to communicate with Microsoft Kinect 2 devices.

Note that this library is completely different from libfreenect in PR #7627 and has its own versioning. Hence a separate package.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@sh0 sh0 marked this pull request as draft October 10, 2021 00:56
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@sh0 sh0 marked this pull request as ready for review October 10, 2021 12:23
recipes/libfreenect2/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libfreenect2/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libfreenect2/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libfreenect2/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@sh0
Copy link
Contributor Author

sh0 commented Oct 14, 2021

From the test package it seems freenect2_INCLUDE_DIRS, freenect2_INCLUDE_DIR and freenect2_LIBRARIES are created in Findfreenect2.cmake so we probably don't need extra variables. It only works with cmake_find_package, but that is also the style of upstream CMake files so we should be fine now.

@madebr
Copy link
Contributor

madebr commented Oct 14, 2021

From the test package it seems freenect2_INCLUDE_DIRS, freenect2_INCLUDE_DIR and freenect2_LIBRARIES are created in Findfreenect2.cmake so we probably don't need extra variables. It only works with cmake_find_package, but that is also the style of upstream CMake files so we should be fine now.

I"m unsure how this will work in conan 2.0 when cmake_find_package and cmake_find_package_multi are deprecated.
But I guess that's thoughts for later.

@conan-center-bot
Copy link
Collaborator

All green in build 7 (6f83c63cf5bf63ccdf6cf46b32633d0880983605):

  • libfreenect2/0.2.1@:
    All packages built successfully! (All logs)

@sh0 sh0 requested a review from uilianries October 16, 2021 12:38
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 332e8fe into conan-io:master Oct 20, 2021
@sh0 sh0 deleted the libfreenect2-package branch October 20, 2021 20:28
ivanvurbanov pushed a commit to ivanvurbanov/conan-center-index that referenced this pull request Dec 2, 2021
* libfreenect2: Add new libfreenect2 package.

* libfreenect2: Add missing system libraries and Macos frameworks.

* libfreenect2: Add more missing Macos frameworks.

* libfreenect2: Add resource generation patch.

* libfreenect2: Find library name automatically.

* libfreenect2: Removed get_safe usage as recommended.

* libfreenect2: Test package update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants