add faac/1.28 #7414
Merged
add faac/1.28 #7414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jgsogo
reviewed
Sep 26, 2021
There was a problem hiding this comment.
Looking good! 👍
Please, use targets to consume packages: https://github.com/conan-io/conan-center-index/blob/master/docs/reviewing.md#cmake-targets (more info).
|
All green in build 4 (
|
SSE4
approved these changes
Sep 27, 2021
jgsogo
approved these changes
Sep 27, 2021
uilianries
reviewed
Sep 27, 2021
| return self._autotools | ||
| self._autotools = AutoToolsBuildEnvironment(self, win_bash=tools.os_info.is_windows) | ||
| with tools.chdir(os.path.join(self.build_folder, self._source_subfolder)): | ||
| self.run("./bootstrap", win_bash=tools.os_info.is_windows) |
There was a problem hiding this comment.
I would suggest enforcing chmod +x just in case, depending the environment, the user can have a permission error. There is an example here
uilianries
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: faac/1.28
conan-center hook activated.