Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boost] add patch for 1.72 #712

Merged
merged 7 commits into from
Feb 21, 2020
Merged

Conversation

SSE4
Copy link
Contributor

@SSE4 SSE4 commented Jan 20, 2020

closes: #711

add an official patch from boost release notes: https://www.boost.org/users/history/version_1_72_0.html

Specify library name and version: boost/1.72.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

Signed-off-by: SSE4 <tomskside@gmail.com>
@conan-center-bot
Copy link
Collaborator

Some configurations of 'boost/1.72.0' failed in build 1 (38b4d5e457e9157df542ad24d4ae593f5cb95fcf):

@uilianries
Copy link
Member

@SSE4 Is it another patch's bug, or this patch doesn't comport 1.72 ?

�[1m�[36mpatches/0001-revert-cease-dependence-on-range.patch: source file is different - b'boost/coroutine/asymmetric_coroutine.hpp'�[0m

@SSE4
Copy link
Contributor Author

SSE4 commented Jan 20, 2020

@SSE4
Copy link
Contributor Author

SSE4 commented Jan 30, 2020

this is very suspicious an official patch doesn't apply...

@uilianries
Copy link
Member

I need to check it, maybe that patch tool in Conan is bugged again 😞

@conan-center-bot
Copy link
Collaborator

Some configurations of 'boost/1.72.0' failed in build 2 (38b4d5e457e9157df542ad24d4ae593f5cb95fcf):

Signed-off-by: SSE4 <tomskside@gmail.com>
Signed-off-by: SSE4 <tomskside@gmail.com>
@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@SSE4
Copy link
Contributor Author

SSE4 commented Feb 12, 2020

okay, it turns out patch was created against the develop, and conan (patch-ng) fails to apply that as source file is different. I had to cherry pick the patch and format it again. with new line numbers, conan is finally happy.

@danimtb
Copy link
Member

danimtb commented Feb 12, 2020

Unexpected error coming from making new commits when this PR has still conflicts. Something to be improved

@conan-center-bot
Copy link
Collaborator

Some configurations of 'boost/1.69.0' failed in build 4 (7c8218d7da2a9ee8d420da65d3d5f783e823897b):

Signed-off-by: SSE4 <tomskside@gmail.com>
@danimtb danimtb mentioned this pull request Feb 12, 2020
4 tasks
@conan-center-bot
Copy link
Collaborator

Some configurations of 'boost/1.69.0' failed in build 5 (7ae3b8deb63f4cd8cdbad6f665f110859ef4d826):

@uilianries
Copy link
Member

For some reason, I can't reproduce it when running with the Docker image conanio/gcc5:

https://gist.github.com/uilianries/7472546a1f4c404f29633791cf817252

It works pretty well actually 🤔

@SSE4
Copy link
Contributor Author

SSE4 commented Feb 12, 2020

interesting :) I am looking into it

Signed-off-by: SSE4 <tomskside@gmail.com>
@conan-center-bot
Copy link
Collaborator

Some configurations of 'boost/1.69.0' failed in build 6 (834e92f1acdeb89ae3179379db010f5ae07d4ca3):

@SSE4
Copy link
Contributor Author

SSE4 commented Feb 13, 2020

@danimtb seems like build stuck

@uilianries
Copy link
Member

Yes, 22h to build Boost?

@conan-center-bot
Copy link
Collaborator

All green in build 7 (835f4b7aaa613f122fa653a5f1ffa4d55459dcf7)! 😊

@danimtb danimtb merged commit 644a58f into conan-io:master Feb 21, 2020
@CroydonBot CroydonBot deleted the boost_72_patch branch February 21, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] boost/1.72.0: Doesn't build on MacOS
4 participants