Add proxy package for libx11 #678
Conversation
|
Some configurations of 'libx11/system' failed in build 1 (
|
|
|
||
| def package(self): | ||
| tools.download("https://gitlab.freedesktop.org/xorg/lib/libx11/raw/master/COPYING", filename="COPYING") | ||
| self.copy("COPYING", dst="licenses") |
There was a problem hiding this comment.
Is it really useful to have a license file when you don't distribute anything ?
| def system_requirements(self): | ||
| installer = self._system_packages() | ||
| if not installer.installed(self._required_system_package): | ||
| raise ConanInvalidConfiguration( |
There was a problem hiding this comment.
Is the plan to have libx11-dev installed in C3I build configurations ? Otherwise that would drastically reduce this package's usefulness, because it would not be possible to require it from any CCI recipe.
There was a problem hiding this comment.
Yes, they should be installed in CCI, if not all these kinds of recipes would be useless as you say.
| homepage = "https://www.x.org/wiki/" | ||
| description = "Client interface to the X Window System, otherwise known as \'Xlib\'", | ||
| settings = "os", "compiler", "build_type", "arch" | ||
| _required_system_package = "libx11-dev" |
There was a problem hiding this comment.
would be much better to use pkg-config to check package availability, so it would be completely distro agnostic
|
All green in build 2 (
|
recipes/libx11/all/conanfile.py
Outdated
|
|
||
|
|
||
| def package_info(self): | ||
| if self._system_packages().installed("pkg-config"): |
There was a problem hiding this comment.
I believe without pkg-config it's hard to deduce all correct flags. -lX11 isn't always enough. I'd say require pkg-config and fail otherwise.
|
Some configurations of 'libx11/system' failed in build 3 (
|
|
Closing: #641 (comment) |
Specify library name and version: libx11/system
This is a proxy package for libx11.Tthis means that this package will verify if x11 is installed in the user's system and populate the
cpp_infowith the required information.When, in the near future, a package for this library is created, this can be transparently substituted in the consumer without requiring any changes.
Related to: #641
conan-center hook activated.