-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add s2let/2.2.4 package #5550
Add s2let/2.2.4 package #5550
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Thanks @SpaceIm, I've been meaning to puzzle out how to make cfitsio optional but couldn't quite figure it out! |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested:
- do not build tests
- use final release instead of RC
In his defense, if you look at the last PRs https://github.com/conan-io/conan-center-index/pulls?q=is%3Apr+is%3Aclosed+author%3Amdavezac We have seen code not compiling but most of it is we provided improvements and the patches get integrated before the PR is merged. If project maintainers work with us to incorporate patches, I think it's better then the messiness of #3951 I feel OP has respected the rules but it's always good to have a refresher. |
I didn't mean to be rude, but from time to time I need to play policeman here. We all agree that this is not a CI service, and we all agree that the way this PR and related recipes are being added to CCI is not affecting badly other PRs that are being built (time/resources)... but, also, we all need to understand that this scenario is something that could happen and we need to pay attention to it. It is great to see that the pull-requests to ConanCenter and the reviews are contributing to improving the original project. It is, without any doubt, one of the best things that could happen here. And I truly believe that we all are contributing to improving the C++ ecosystem, and I'm so grateful for it. But (there is always a but), I need to remember some rules from time to time, not based on my own feelings, neither on how big/small the project is. We are not closing the pull-request or banning anyone here, so please, I apologize if it sounded rude. Please, keep pushing changes until it is ready to merge 🚀 |
@jgsogo, thanks for your review and the policy remainder. Just to confirm what @prince-chrismc said, the upstream has been in rc while waiting for any necessary changes arising from this PR and only this PR. The upstream has it's own CI with more tests than are suitable for conan-center. So the intent is not to check for anything here except whether we can build with conan. |
All green in build 4 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
astro-informatics!! 🚀 🚀 🚀
Thank you for all your comments and reviews! |
* add s2let/2.2.3 * Apply changes from code review comments * Apply suggestions from code review Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * Update URL and SHA for upstream release Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Specify library name and version: s2let/2.2.4
s2let is a fast wavelet transform on the sphere. It can be used for radio-inteferometry, VR, or anywhere a signal on the sphere is analyzed. This PR is a follow up to ssht and astro-informatics-so3 added recently.
conan-center hook activated.