Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[poppler-data] Add version 0.4.10 #5396

Merged
merged 2 commits into from
May 4, 2021

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented May 2, 2021

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot conan-center-bot added the Bump version PR bumping version without recipe modifications label May 2, 2021
@conan-center-bot

This comment has been minimized.

@madebr
Copy link
Contributor

madebr commented May 2, 2021

You can reduce the patch to avoid having to create a new one:

--- CMakeLists.txt
+++ CMakeLists.txt
@@ -6,1 +6,3 @@
-set(datadir ${CMAKE_INSTALL_PREFIX}/share)
+if(NOT datadir)
+  set(datadir ${CMAKE_INSTALL_PREFIX}/share)
+endif()

@conan-center-bot conan-center-bot removed the Bump version PR bumping version without recipe modifications label May 3, 2021
@conan-center-bot
Copy link
Collaborator

All green in build 2 (5a8903d5e09b0f646e8a2299cce0b35773110672):

  • poppler-data/0.4.9@:
    All packages built successfully! (All logs)

  • poppler-data/0.4.10@:
    All packages built successfully! (All logs)

@jgsogo jgsogo requested a review from uilianries May 3, 2021 14:16
@conan-center-bot conan-center-bot merged commit 7f66a09 into conan-io:master May 4, 2021
@jgsogo jgsogo deleted the poppler-data branch May 4, 2021 06:31
AlvaroFS pushed a commit to AlvaroFS/conan-center-index that referenced this pull request May 7, 2021
* [poppler-data] Add  version 0.4.10

* modify patch following suggestion by @madebr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants