Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding recipe for Himalaya #4681

Closed
wants to merge 11 commits into from
Closed

Conversation

Expander
Copy link
Contributor

Specify library name and version: himalaya/4.1.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@Expander
Copy link
Contributor Author

Expander commented Feb 25, 2021

The build fails because a (required) FORTRAN compiler is missing. How can I fix this? Should I exclude MacOS? (In principle this is not necessary, because one can install gfortran on MacOS via brew.)

recipes/himalaya/all/conanfile.py Show resolved Hide resolved
recipes/himalaya/all/conanfile.py Outdated Show resolved Hide resolved
recipes/himalaya/all/conanfile.py Outdated Show resolved Hide resolved
recipes/himalaya/all/conanfile.py Show resolved Hide resolved
recipes/himalaya/all/conanfile.py Show resolved Hide resolved
recipes/himalaya/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
Expander and others added 6 commits February 25, 2021 15:30
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

It seems like gfortran is in trouble.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Apr 6, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 6, 2021
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@stale stale bot removed the stale label Apr 7, 2021
@conan-center-bot

This comment has been minimized.

@Expander
Copy link
Contributor Author

Would it ok, if MacOS support would currently be disabled for this package? This would at least allow using the package on all the other platforms for the moment.

@stale
Copy link

stale bot commented May 18, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 18, 2021
@Expander
Copy link
Contributor Author

I'm sorry, but I'm not sure what I can do to help with this issue. Is there any workaround that can be used for the moment?

@stale stale bot removed the stale label May 18, 2021
@uilianries
Copy link
Member

This recipe requires gfortran. Our current recipe is broken. We have some options here:

  • Fix gfortran recipe (not easy)
  • Update Docker images (Install gfortran)
  • Provide Conan GCC package with fortran support

All three are complex, but the easiest is the second.

def config_options(self):
if self.settings.os == "Windows":
del self.options.fPIC

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def configure(self):
if self.options.shared:
del self.options.fPIC

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the proposal!
But tbh, why should fPIC be deleted if shared is enabled? Isn't this the wrong way around?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes no sense disabling fPIC when building shared library, so we disable it. Otherwise, it would affect the package ID, for both values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, now I think I understand. :) You are saying that since Himalaya always builds a shared library, the fPIC option can be deleted completely. Is this correct?

@stale
Copy link

stale bot commented Jun 17, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 17, 2021
@stale stale bot removed the stale label Jun 28, 2021
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Failure in build 14 (039b6b66603e4fbda7e9dd66d7409b0dcbdd5fe2):

  • himalaya/4.1.1@:
    CI failed to create some packages (All logs)

    Logs for packageID c302d7be7a18d639806b9c0bb417ea5f6b5614b0:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=9
    os=Linux
    os_build=Linux
    [options]
    himalaya:shared=False
    
    [...]
    -- Detecting Fortran compiler ABI info
    -- Detecting Fortran compiler ABI info - failed
    -- Check for working Fortran compiler: /home/conan/w/BuildSingleReference/.conan/data/gfortran/10.2/_/_/package/4db1be536558d833e52e862fd84d64d75c2b3656/bin/gfortran
    -- Check for working Fortran compiler: /home/conan/w/BuildSingleReference/.conan/data/gfortran/10.2/_/_/package/4db1be536558d833e52e862fd84d64d75c2b3656/bin/gfortran - broken
    -- Configuring incomplete, errors occurred!
    See also "/home/conan/w/BuildSingleReference/.conan/data/himalaya/4.1.1/_/_/build/c302d7be7a18d639806b9c0bb417ea5f6b5614b0/build_subfolder/CMakeFiles/CMakeOutput.log".
    See also "/home/conan/w/BuildSingleReference/.conan/data/himalaya/4.1.1/_/_/build/c302d7be7a18d639806b9c0bb417ea5f6b5614b0/build_subfolder/CMakeFiles/CMakeError.log".
    himalaya/4.1.1: 
    gfortran: fatal error: cannot execute ‘cc1’: execvp: No such file or directory
    compilation terminated.
    CMake Error at /usr/share/cmake-3.18/Modules/CMakeTestFortranCompiler.cmake:51 (message):
      The Fortran compiler
    
        "/home/conan/w/BuildSingleReference/.conan/data/gfortran/10.2/_/_/package/4db1be536558d833e52e862fd84d64d75c2b3656/bin/gfortran"
    
      is not able to compile a simple test program.
    
      It fails with the following output:
    
        Change Dir: /home/conan/w/BuildSingleReference/.conan/data/himalaya/4.1.1/_/_/build/c302d7be7a18d639806b9c0bb417ea5f6b5614b0/build_subfolder/CMakeFiles/CMakeTmp
        
        Run Build Command(s):/usr/bin/make cmTC_5a588/fast && /usr/bin/make  -f CMakeFiles/cmTC_5a588.dir/build.make CMakeFiles/cmTC_5a588.dir/build
        make[1]: Entering directory '/home/conan/w/BuildSingleReference/.conan/data/himalaya/4.1.1/_/_/build/c302d7be7a18d639806b9c0bb417ea5f6b5614b0/build_subfolder/CMakeFiles/CMakeTmp'
        Building Fortran object CMakeFiles/cmTC_5a588.dir/testFortranCompiler.f.o
        /home/conan/w/BuildSingleReference/.conan/data/gfortran/10.2/_/_/package/4db1be536558d833e52e862fd84d64d75c2b3656/bin/gfortran    -c /home/conan/w/BuildSingleReference/.conan/data/himalaya/4.1.1/_/_/build/c302d7be7a18d639806b9c0bb417ea5f6b5614b0/build_subfolder/CMakeFiles/CMakeTmp/testFortranCompiler.f -o CMakeFiles/cmTC_5a588.dir/testFortranCompiler.f.o
        gfortran: fatal error: cannot execute ‘f951’: execvp: No such file or directory
        compilation terminated.
        make[1]: *** [CMakeFiles/cmTC_5a588.dir/build.make:85: CMakeFiles/cmTC_5a588.dir/testFortranCompiler.f.o] Error 1
        make[1]: Leaving directory '/home/conan/w/BuildSingleReference/.conan/data/himalaya/4.1.1/_/_/build/c302d7be7a18d639806b9c0bb417ea5f6b5614b0/build_subfolder/CMakeFiles/CMakeTmp'
        make: *** [Makefile:140: cmTC_5a588/fast] Error 2
        
        
    
      
    
      CMake will not be able to correctly generate this project.
    Call Stack (most recent call first):
      source_subfolder/CMakeLists.txt:2 (project)
    
    
    eigen/3.3.9: WARN: Lib folder doesn't exist, can't collect libraries: /home/conan/w/BuildSingleReference/.conan/data/eigen/3.3.9/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/lib
    eigen/3.3.9: WARN: Lib folder doesn't exist, can't collect libraries: /home/conan/w/BuildSingleReference/.conan/data/eigen/3.3.9/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/lib
    himalaya/4.1.1: WARN: Build folder is dirty, removing it: /home/conan/w/BuildSingleReference/.conan/data/himalaya/4.1.1/_/_/build/c302d7be7a18d639806b9c0bb417ea5f6b5614b0
    himalaya/4.1.1: ERROR: Package 'c302d7be7a18d639806b9c0bb417ea5f6b5614b0' build failed
    himalaya/4.1.1: WARN: Build folder /home/conan/w/BuildSingleReference/.conan/data/himalaya/4.1.1/_/_/build/c302d7be7a18d639806b9c0bb417ea5f6b5614b0
    ERROR: himalaya/4.1.1: Error in build() method, line 65
    	cmake = self._configure_cmake()
    while calling '_configure_cmake', line 73
    	self._cmake.configure(build_folder=self._build_subfolder)
    	ConanException: Error 1 while executing cd '/home/conan/w/BuildSingleReference/.conan/data/himalaya/4.1.1/_/_/build/c302d7be7a18d639806b9c0bb417ea5f6b5614b0/build_subfolder' && cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE="Release" -DCONAN_IN_LOCAL_CACHE="ON" -DCONAN_COMPILER="gcc" -DCONAN_COMPILER_VERSION="9" -DCONAN_CXX_FLAGS="-m64" -DCONAN_SHARED_LINKER_FLAGS="-m64" -DCONAN_C_FLAGS="-m64" -DCONAN_LIBCXX="libstdc++11" -DBUILD_SHARED_LIBS="OFF" -DCMAKE_INSTALL_PREFIX="/home/conan/w/BuildSingleReference/.conan/data/himalaya/4.1.1/_/_/package/c302d7be7a18d639806b9c0bb417ea5f6b5614b0" -DCMAKE_INSTALL_BINDIR="bin" -DCMAKE_INSTALL_SBINDIR="bin" -DCMAKE_INSTALL_LIBEXECDIR="bin" -DCMAKE_INSTALL_LIBDIR="lib" -DCMAKE_INSTALL_INCLUDEDIR="include" -DCMAKE_INSTALL_OLDINCLUDEDIR="include" -DCMAKE_INSTALL_DATAROOTDIR="share" -DCONAN_CMAKE_POSITION_INDEPENDENT_CODE="ON" -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY="ON" -DCONAN_EXPORTED="1" -DBUILD_EXAMPLES="False" -Wno-dev '/home/conan/w/BuildSingleReference/.conan/data/himalaya/4.1.1/_/_/build/c302d7be7a18d639806b9c0bb417ea5f6b5614b0'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@stale
Copy link

stale bot commented Jul 30, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added stale and removed stale labels Jul 30, 2021
@uilianries
Copy link
Member

@Expander I have some good news. We are developing new docker images with fortran supported. They should become official in some months, but unfortunately we can't your case right now. The gfortran package is broken and only way that I see to fix it, is importing all gcc libraries and apps (not good idea).

@Expander
Copy link
Contributor Author

Many thanks for the good news! Then let's wait with this PR until fortran is available.

@stale
Copy link

stale bot commented Aug 29, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 29, 2021
@stale
Copy link

stale bot commented Sep 28, 2021

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants