Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raylib: use external glfw + fix CMake imported target #4499

Merged
merged 10 commits into from
Feb 9, 2021
Merged

raylib: use external glfw + fix CMake imported target #4499

merged 10 commits into from
Feb 9, 2021

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Feb 6, 2021

Specify library name and version: raylib/all

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@github-actions github-actions bot mentioned this pull request Feb 6, 2021
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm
define USE_LIBTYPE_SHARED if msvc and shared
b0aecb9
@SpaceIm
remove transitive system dependencies
516b68d 
removed system libs were coming from glfw and are not direct dependencies of raylib
@SpaceIm
remove CUSTOMIZE_BUILD CMake option
2a266e9 
not available in raylib 3.5.0
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Feb 6, 2021

Actually, raylib is broken with external glfw on windows: raysan5/raylib#1259

@conan-center-bot
Copy link
Collaborator

All green in build 4 (d590666ff273c63c984e933231de2d6b7844f9c1):

  • raylib/3.5.0@:
    All packages built successfully! (All logs)

@SSE4 SSE4 requested a review from uilianries February 7, 2021 07:07
@conan-center-bot conan-center-bot merged commit 5266fe6 into conan-io:master Feb 9, 2021
@SpaceIm SpaceIm deleted the fix/raylib-unvendor branch February 9, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@intelligide intelligide intelligide approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@uilianries uilianries Awaiting requested review from uilianries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SpaceIm @conan-center-bot @SSE4 @intelligide @prince-chrismc