Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libsafec/3.6.0 #4434

Merged
merged 24 commits into from
Feb 8, 2021
Merged

Add libsafec/3.6.0 #4434

merged 24 commits into from
Feb 8, 2021

Conversation

klimkin
Copy link
Contributor

@klimkin klimkin commented Jan 31, 2021

safeclib/3.6.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@klimkin
Copy link
Contributor Author

klimkin commented Jan 31, 2021

@rurban I am a bit confused about the package name. In the docs it's referred as safeclib, but the sources use libsafec.pc. Could you clarify the package name please: safeclib or libsafec?

@conan-center-bot

This comment has been minimized.

Sign in to view
@rurban
Copy link

rurban commented Jan 31, 2021

@rurban I am a bit confused about the package name. In the docs it's referred as safeclib, but the sources use libsafec.pc. Could you clarify the package name please: safeclib or libsafec?

I'm also confused, but I've inherited the name from Cisco and cannot change it. Do as you wish.
The repo and docs are as safeclib, the pc is named proper. The packages in Debian/Redhat will likely use libsafec/-dev{,el}, maybe the docs package will use safeclib-docs. People should just find it.

Thanks for doing this.

@klimkin
Copy link
Contributor Author

klimkin commented Jan 31, 2021

@rurban I am a bit confused about the package name. In the docs it's referred as safeclib, but the sources use libsafec.pc. Could you clarify the package name please: safeclib or libsafec?

I'm also confused, but I've inherited the name from Cisco and cannot change it. Do as you wish.
The repo and docs are as safeclib, the pc is named proper. The packages in Debian/Redhat will likely use libsafec/-dev{,el}, maybe the docs package will use safeclib-docs. People should just find it.

Thanks for doing this.

Renamed to libsafec for alignment with other distributions.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@klimkin klimkin changed the title Add safeclib/3.6.0 Add libsafec/3.6.0 Feb 1, 2021
@github-actions github-actions bot mentioned this pull request Feb 1, 2021
Open
prince-chrismc
prince-chrismc suggested changes Feb 1, 2021
View reviewed changes
recipes/libsafec/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libsafec/all/patches/fix-ndebug-redifinition.patch Outdated Show resolved Hide resolved
recipes/libsafec/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libsafec/all/conanfile.py Show resolved Hide resolved
@klimkin @prince-chrismc
Update recipes/libsafec/all/conanfile.py
23d084b 
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@klimkin @intelligide
Update recipes/libsafec/all/test_package/conanfile.py
a58d400 
Co-authored-by: Yoann Potinet <intelligide@hotmail.fr>
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
theirix
theirix previously approved these changes Feb 5, 2021
View reviewed changes
@conan-center-bot

This comment has been minimized.

Sign in to view
madebr
madebr previously approved these changes Feb 5, 2021
View reviewed changes
@prince-chrismc
Copy link
Contributor

Please do not force push it makes it more difficult to review!

(the last two commits didnt change anything)

prince-chrismc
prince-chrismc previously approved these changes Feb 5, 2021
View reviewed changes
@klimkin klimkin dismissed stale reviews from prince-chrismc and madebr via b65111d February 7, 2021 02:57
@conan-center-bot
Copy link
Collaborator

All green in build 17 (b65111d6bfb462444c2ee6b71ec0f9386f7d6114)! 😊

@klimkin
Copy link
Contributor Author

klimkin commented Feb 7, 2021

Sorry for churn on the reviews, there been no changes and no force-pushes since cb9a21564357cd6fc04feed81f2549ab3fea01ef. Just some erroneous commits I had to revert.

@conan-center-bot

This comment has been minimized.

Sign in to view
prince-chrismc
prince-chrismc previously approved these changes Feb 7, 2021
View reviewed changes
@klimkin @SpaceIm
Update recipes/libsafec/all/conanfile.py
dbe22de 
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@conan-center-bot
Copy link
Collaborator

All green in build 19 (dbe22de8d944ffefffdafd7d61fb2ba722347c54)! 😊

@conan-center-bot conan-center-bot merged commit f1f0396 into conan-io:master Feb 8, 2021
@klimkin klimkin deleted the feature/add-safec branch February 10, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theirix theirix theirix approved these changes

@uilianries uilianries uilianries approved these changes

@intelligide intelligide intelligide approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@SpaceIm SpaceIm SpaceIm approved these changes

@madebr madebr madebr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@klimkin @conan-center-bot @rurban @prince-chrismc @theirix @madebr @uilianries @intelligide @SpaceIm