Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt 6.0.1 #4412

Merged
merged 36 commits into from
Feb 23, 2021
Merged

Qt 6.0.1 #4412

merged 36 commits into from
Feb 23, 2021

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented Jan 29, 2021

Specify library name and version: qt/6.0.1

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Jan 29, 2021

See you in 6 months for the review 😄

I have a simple question: could it be modularized?

@ericLemanissier
Copy link
Contributor Author

I did not try, but I read that it could be. The question is: how can we integrate a modularized package in CCI ? Currently each recipe has to generate exactly one package, and we certainly don't want to cut and paste the same recipe for each qt modules. Is python_requires allowed ?
Anyway, I don't think the possibility of modularization should freeze the progress of this monolithic recipe, because both recipe can co-exist, and the modularization is still only an hypothesis.

@conan-center-bot

This comment has been minimized.

@ericLemanissier

This comment has been minimized.

@Croydon
Copy link
Contributor

Croydon commented Jan 29, 2021

We do have https://conan.io/center/strawberryperl if that is of any help

by the way, you linked to Qt 5, this seems to be the one for Qt 6 https://doc.qt.io/qt-6/windows-requirements.html#building-from-source

Which kinda raises the question why perl was not needed for Qt 5?

@ericLemanissier

This comment has been minimized.

@Croydon
Copy link
Contributor

Croydon commented Jan 29, 2021

Maybe the own compiler isn't a problem anymore due to CMake?

@ericLemanissier

This comment has been minimized.

@ericLemanissier
Copy link
Contributor Author

lol, thanks anyway @danimtb

@ericriff
Copy link
Contributor

Aren't this changes also needed on Qt6?
#4577

@ericLemanissier
Copy link
Contributor Author

ericLemanissier commented Feb 16, 2021

I did not have the time to check it yet. I won't integrate in qt6 before it is merged in qt5 anyway, to avoid doubling the work.

@conan-center-bot
Copy link
Collaborator

All green in build 36 (746a989bd3159013e34d9c7c7910ab0308cd36d5)! 😊

SpaceIm
SpaceIm previously approved these changes Feb 19, 2021
intelligide
intelligide previously approved these changes Feb 19, 2021
it is unused and obsolete
@conan-center-bot
Copy link
Collaborator

Some configurations of 'qt/6.0.1' failed in build 37 (b9e0fc3733fffd03e9b31344fa7e3478ce0644f5):

@jgsogo
Copy link
Contributor

jgsogo commented Feb 19, 2021

Wow. Right now we are uploading the packages for zlib (just merged to master)... recipe is there, but some binaries not yet. Concurrency in ConanCenter. 😖

@SpaceIm
Copy link
Contributor

SpaceIm commented Feb 19, 2021

Shouldn't there be a mechanism to ensure that a recipe's revision is not visible until all packages have been uploaded?

@jgsogo
Copy link
Contributor

jgsogo commented Feb 19, 2021

Shouldn't there be a mechanism to ensure that a recipe's revision is not visible until all packages have been uploaded?

Totally agree. Right now we are copying packages via download/upload which takes a lot of time. In the near future (it is already implemented in Artifactory) we will be able to promote packages: an API call telling Artifactory to move/copy packages from one repo to another, it should be extremely fast, just a database insert. We are looking forward to that upgrade.

@conan-center-bot
Copy link
Collaborator

All green in build 38 (b9e0fc3733fffd03e9b31344fa7e3478ce0644f5)! 😊

def package(self):
cmake = self._configure_cmake()
cmake.install()
with open(os.path.join(self.package_folder, "bin", "qt.conf"), "w") as f:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just in case (don't need to change now):

  • tools.save
  • textwrap.dedent

@conan-center-bot conan-center-bot merged commit ce53208 into conan-io:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.