-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt 6.0.1 #4412
Qt 6.0.1 #4412
Conversation
also, add cmake as a build_requirement, because recent version is needed
Also, remove non-existent modules and their dependencies
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
this fixes msvc
See you in 6 months for the review 😄 I have a simple question: could it be modularized? |
I did not try, but I read that it could be. The question is: how can we integrate a modularized package in CCI ? Currently each recipe has to generate exactly one package, and we certainly don't want to cut and paste the same recipe for each qt modules. Is |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
We do have https://conan.io/center/strawberryperl if that is of any help by the way, you linked to Qt 5, this seems to be the one for Qt 6 https://doc.qt.io/qt-6/windows-requirements.html#building-from-source Which kinda raises the question why perl was not needed for Qt 5? |
This comment has been minimized.
This comment has been minimized.
Maybe the own compiler isn't a problem anymore due to CMake? |
This comment has been minimized.
This comment has been minimized.
lol, thanks anyway @danimtb |
Aren't this changes also needed on Qt6? |
I did not have the time to check it yet. I won't integrate in qt6 before it is merged in qt5 anyway, to avoid doubling the work. |
All green in build 36 (
|
b9e0fc3
it is unused and obsolete
Some configurations of 'qt/6.0.1' failed in build 37 (
|
Wow. Right now we are uploading the packages for |
Shouldn't there be a mechanism to ensure that a recipe's revision is not visible until all packages have been uploaded? |
Totally agree. Right now we are copying packages via download/upload which takes a lot of time. In the near future (it is already implemented in Artifactory) we will be able to promote packages: an API call telling Artifactory to move/copy packages from one repo to another, it should be extremely fast, just a database insert. We are looking forward to that upgrade. |
All green in build 38 (
|
def package(self): | ||
cmake = self._configure_cmake() | ||
cmake.install() | ||
with open(os.path.join(self.package_folder, "bin", "qt.conf"), "w") as f: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just in case (don't need to change now):
tools.save
textwrap.dedent
Specify library name and version: qt/6.0.1
conan-center hook activated.