Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bullet3/2.89 recipe #440

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Add bullet3/2.89 recipe #440

merged 1 commit into from
Jan 31, 2020

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Dec 10, 2019

Specify library name and version: bullet3/2.88bullet3/2.89

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

The test_package test fails because the CMake variable Bullet_ROOT is not available in the cmake_find_package generator.
This Bullet_ROOT variable is required to emulate the variables defined in https://github.com/bulletphysics/bullet3/blob/6c722f8f94413b7096e6903e11bc087800511088/BulletConfig.cmake.in
See conan-io/conan#6202

@conan-center-bot
Copy link
Collaborator

Some configurations of 'bullet3/2.88' have failed:

lasote
lasote previously requested changes Dec 10, 2019
recipes/bullet3/all/bullet_extra.cmake Outdated Show resolved Hide resolved
recipes/bullet3/all/bullet_extra.cmake Outdated Show resolved Hide resolved
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution I'll open a PR to your branch, with my suggestion, so you don't need to spend time on it.

recipes/bullet3/all/conanfile.py Outdated Show resolved Hide resolved
recipes/bullet3/all/conanfile.py Outdated Show resolved Hide resolved
recipes/bullet3/all/conanfile.py Outdated Show resolved Hide resolved
recipes/bullet3/all/conanfile.py Outdated Show resolved Hide resolved
recipes/bullet3/all/conanfile.py Outdated Show resolved Hide resolved
recipes/bullet3/all/conanfile.py Outdated Show resolved Hide resolved
recipes/bullet3/all/conanfile.py Outdated Show resolved Hide resolved
recipes/bullet3/all/conanfile.py Outdated Show resolved Hide resolved
recipes/bullet3/all/conanfile.py Outdated Show resolved Hide resolved
recipes/bullet3/all/test_package/.gitignore Outdated Show resolved Hide resolved
@madebr madebr force-pushed the bullet3 branch 2 times, most recently from 18c5a92 to 3c6b500 Compare December 10, 2019 15:10
@conan-center-bot
Copy link
Collaborator

Some configurations of 'bullet3/2.88' have failed:

@conan-center-bot
Copy link
Collaborator

All green! 😊

@madebr
Copy link
Contributor Author

madebr commented Dec 10, 2019

@uilianries The bot said it succeeded but by looking at the logs it failed.

@uilianries
Copy link
Member

@madebr thanks for reporting!

@conan-center-bot
Copy link
Collaborator

Some configurations of 'bullet3/2.88' have failed:

@conan-center-bot
Copy link
Collaborator

Some configurations of 'bullet3/2.88' have failed:

@madebr madebr changed the title Add bullet3/2.88 recipe Add bullet3/2.89 recipe Jan 20, 2020
@conan-center-bot
Copy link
Collaborator

Some configurations of 'bullet3/2.88' failed in build 9 (bfd25e683a3d1c2d6bbd937b5efbb6f883fdd190):

@conan-center-bot
Copy link
Collaborator

All green in build 10 (93de34937ed566c8bedad937a1f7d742f2647da0)! 😊

@uilianries uilianries requested a review from SSE4 January 28, 2020 21:59
@danimtb danimtb dismissed lasote’s stale review January 31, 2020 11:07

outdated. Already fixed

@danimtb danimtb merged commit 243770a into conan-io:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants