minizip-ng: Add 3.0.0 #4394

intelligide · 2021-01-28T00:48:51Z

Specify library name and version: minizip-ng/3.0.0

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

Closes #4386.

recipes/minizip-ng/all/conanfile.py

Co-authored-by: Marian Klymov <nekto1989@gmail.com>

recipes/minizip-ng/all/conanfile.py

uilianries · 2021-01-28T14:13:35Z

recipes/minizip-ng/all/conanfile.py

+        self._cmake.definitions["MZ_LZMA"] = self.options.with_lzma
+        self._cmake.definitions["MZ_ZSTD"] = self.options.with_zstd
+        self._cmake.definitions["MZ_OPENSSL"] = self.options.with_openssl
+        self._cmake.definitions["MZ_LIBCOMP"] = tools.is_apple_os(self.settings.os) and self.options.with_libcomp


Suggested change

self._cmake.definitions["MZ_LIBCOMP"] = tools.is_apple_os(self.settings.os) and self.options.with_libcomp

self._cmake.definitions["MZ_LIBCOMP"] = tools.is_apple_os(self.settings.os) and self.options.with_libcomp

Does make sense keep with_libcomp for all configurations, if it is only used for iOS?

It's only support on Apple https://github.com/zlib-ng/minizip-ng/blob/6f17da582d2327c8cdc43622ddd31a185b6ef5fb/CMakeLists.txt#L182

So it can be remove from package ID for other OSs, it's one item less to be computed on package ID.

recipes/minizip-ng/all/conanfile.py

prince-chrismc

Do these flags https://github.com/zlib-ng/minizip-ng/blob/6f17da582d2327c8cdc43622ddd31a185b6ef5fb/CMakeLists.txt#L647-L659 conflict with what conan will set?

prince-chrismc · 2021-01-28T21:18:29Z

recipes/minizip-ng/all/conanfile.py

+        elif self.options.with_libcomp:
+            del self.options.with_zlib


This also needs to be in the validate I suspect https://github.com/zlib-ng/minizip-ng/blob/6f17da582d2327c8cdc43622ddd31a185b6ef5fb/CMakeLists.txt#L189

#4261

prince-chrismc · 2021-01-28T21:19:01Z

recipes/minizip-ng/all/conanfile.py

+        self._cmake.definitions["MZ_LZMA"] = self.options.with_lzma
+        self._cmake.definitions["MZ_ZSTD"] = self.options.with_zstd
+        self._cmake.definitions["MZ_OPENSSL"] = self.options.with_openssl
+        self._cmake.definitions["MZ_LIBCOMP"] = tools.is_apple_os(self.settings.os) and self.options.with_libcomp


It's only support on Apple https://github.com/zlib-ng/minizip-ng/blob/6f17da582d2327c8cdc43622ddd31a185b6ef5fb/CMakeLists.txt#L182

conan-center-bot · 2021-01-29T01:44:23Z

All green in build 13 (9d9ee403eaca58336fc27aa7fb5b7de40c4f6850)! 😊

minizip-ng/3.0.0: Generated 88 packages. All logs here

uilianries · 2021-01-29T13:33:39Z

recipes/minizip-ng/all/conanfile.py

+        if self.options.shared:
+            del self.options.fPIC
+        del self.settings.compiler.cppstd
+        del self.settings.compiler.libcxx


Suggested change

del self.settings.compiler.libcxx

del self.settings.compiler.libcxx

if self.options.mz_compatibility:

self.provides = "minizip"

Nekto89 · 2021-01-29T14:52:54Z

Do these flags https://github.com/zlib-ng/minizip-ng/blob/6f17da582d2327c8cdc43622ddd31a185b6ef5fb/CMakeLists.txt#L647-L659 conflict with what conan will set?

I had to remove them for local build through CMake's ExternalProject because it was overriding /Z7 option

conan-center-bot · 2021-03-07T20:34:45Z

Failure in build 14 (9d9ee403eaca58336fc27aa7fb5b7de40c4f6850):

minizip-ng/3.0.0@:
CI failed to create some packages (All logs)

Logs for packageID 4a78c04cf082e195225965abb7af99bb914b879e:

[settings]
arch=x86_64
arch_build=x86_64
build_type=Debug
compiler=apple-clang
compiler.libcxx=libc++
compiler.version=12.0
os=Macos
os_build=Macos
[options]
minizip-ng:shared=False

-- Found: /Users/jenkins/w/BuildSingleReference@3/.conan/data/openssl/1.1.1i/_/_/package/d98fae1010d1fb9e7f79a1e8a72bbf129d8660a2/lib/libssl.a
-- Library crypto found /Users/jenkins/w/BuildSingleReference@3/.conan/data/openssl/1.1.1i/_/_/package/d98fae1010d1fb9e7f79a1e8a72bbf129d8660a2/lib/libcrypto.a
-- Found: /Users/jenkins/w/BuildSingleReference@3/.conan/data/openssl/1.1.1i/_/_/package/d98fae1010d1fb9e7f79a1e8a72bbf129d8660a2/lib/libcrypto.a
-- Library crypto found /Users/jenkins/w/BuildSingleReference@3/.conan/data/openssl/1.1.1i/_/_/package/d98fae1010d1fb9e7f79a1e8a72bbf129d8660a2/lib/libcrypto.a
-- Found: /Users/jenkins/w/BuildSingleReference@3/.conan/data/openssl/1.1.1i/_/_/package/d98fae1010d1fb9e7f79a1e8a72bbf129d8660a2/lib/libcrypto.a
-- Library ssl found /Users/jenkins/w/BuildSingleReference@3/.conan/data/openssl/1.1.1i/_/_/package/d98fae1010d1fb9e7f79a1e8a72bbf129d8660a2/lib/libssl.a
-- Found: /Users/jenkins/w/BuildSingleReference@3/.conan/data/openssl/1.1.1i/_/_/package/d98fae1010d1fb9e7f79a1e8a72bbf129d8660a2/lib/libssl.a
-- Conan: Using autogenerated FindIconv.cmake
-- Found Iconv: 1.16 (found version "1.16") 
-- Library iconv found /Users/jenkins/w/BuildSingleReference@3/.conan/data/libiconv/1.16/_/_/package/d98fae1010d1fb9e7f79a1e8a72bbf129d8660a2/lib/libiconv.a
-- Found: /Users/jenkins/w/BuildSingleReference@3/.conan/data/libiconv/1.16/_/_/package/d98fae1010d1fb9e7f79a1e8a72bbf129d8660a2/lib/libiconv.a
-- Library charset found /Users/jenkins/w/BuildSingleReference@3/.conan/data/libiconv/1.16/_/_/package/d98fae1010d1fb9e7f79a1e8a72bbf129d8660a2/lib/libcharset.a
-- Found: /Users/jenkins/w/BuildSingleReference@3/.conan/data/libiconv/1.16/_/_/package/d98fae1010d1fb9e7f79a1e8a72bbf129d8660a2/lib/libcharset.a
-- Library minizip found /Users/jenkins/w/BuildSingleReference@3/.conan/data/minizip-ng/3.0.0/_/_/package/4a78c04cf082e195225965abb7af99bb914b879e/lib/libminizip.a
-- Found: /Users/jenkins/w/BuildSingleReference@3/.conan/data/minizip-ng/3.0.0/_/_/package/4a78c04cf082e195225965abb7af99bb914b879e/lib/libminizip.a
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/jenkins/w/BuildSingleReference@3/conan-center-index/recipes/minizip-ng/all/test_package/build/65d5e15cd00ee711cf9c113ff4f3397fea568884

----Running------
> cmake --build '/Users/jenkins/w/BuildSingleReference@3/conan-center-index/recipes/minizip-ng/all/test_package/build/65d5e15cd00ee711cf9c113ff4f3397fea568884' '--' '-j8'
-----------------
Scanning dependencies of target test_package
[ 50%] Building C object CMakeFiles/test_package.dir/test_package.c.o
[HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component openssl::openssl libdir "lib" does not contain any declared library
[HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component zstd::zstd libdir "lib" does not contain any declared library
[HOOK - conan-center.py] post_package_info(): WARN: [LIBRARY DOES NOT EXIST (KB-H054)] Component minizip-ng::minizip-ng libdir "lib" does not contain any declared library
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    CMAKE_INSTALL_BINDIR
    CMAKE_INSTALL_DATAROOTDIR
    CMAKE_INSTALL_INCLUDEDIR
    CMAKE_INSTALL_LIBDIR
    CMAKE_INSTALL_LIBEXECDIR
    CMAKE_INSTALL_OLDINCLUDEDIR
    CMAKE_INSTALL_SBINDIR


/Users/jenkins/w/BuildSingleReference@3/conan-center-index/recipes/minizip-ng/all/test_package/test_package.c:7:19: error: implicit declaration of function 'mz_path_resolve' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    int32_t err = mz_path_resolve("c:\\test\\.", output, sizeof(output));
                  ^
1 error generated.
make[2]: *** [CMakeFiles/test_package.dir/test_package.c.o] Error 1
make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
make: *** [all] Error 2
ERROR: minizip-ng/3.0.0 (test package): Error in build() method, line 12
	cmake.build()
	ConanException: Error 2 while executing cmake --build '/Users/jenkins/w/BuildSingleReference@3/conan-center-index/recipes/minizip-ng/all/test_package/build/65d5e15cd00ee711cf9c113ff4f3397fea568884' '--' '-j8'

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

stale · 2021-04-06T22:17:44Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

minizip-ng: Add 3.0.0

d9c8fde

This comment has been minimized.

Sign in to view

conan-center-bot added the Unexpected Error label Jan 28, 2021

intelligide closed this Jan 28, 2021

intelligide reopened this Jan 28, 2021

This comment has been minimized.

Sign in to view

conan-center-bot added Failed and removed Unexpected Error labels Jan 28, 2021

minizip-ng: Add with_libcomp option

5e53904

This comment has been minimized.

Sign in to view

minizip-ng: Use pkg_config generator

70e97d3

This comment has been minimized.

Sign in to view

intelligide added 3 commits January 27, 2021 21:32

minizip-ng: Fix libbsd

32a6bbb

minizip-ng: Use C11 in test_package

b96ce33

minizip: Fix bzip2 discovery

8364ab6

This comment has been minimized.

Sign in to view

intelligide added 2 commits January 27, 2021 22:46

minizip-ng: Export symbols on Windows

701206b

minizip-ng: Disable zlib when libcomp is enabled

5e2838e

This comment has been minimized.

Sign in to view

minizip-ng: Update CMake minimum version to 3.4

0a625f2

This comment has been minimized.

Sign in to view

conan-center-bot added Unexpected Error and removed Failed labels Jan 28, 2021

intelligide closed this Jan 28, 2021

intelligide reopened this Jan 28, 2021

This comment has been minimized.

Sign in to view

conan-center-bot removed the Unexpected Error label Jan 28, 2021

SSE4 requested a review from uilianries January 28, 2021 07:00

github-actions bot mentioned this pull request Jan 28, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

Nekto89 reviewed Jan 28, 2021

View reviewed changes

recipes/minizip-ng/all/conanfile.py Outdated Show resolved Hide resolved

minizip-ng: Fix license

0d1f86e

Co-authored-by: Marian Klymov <nekto1989@gmail.com>

This comment has been minimized.

Sign in to view

uilianries reviewed Jan 28, 2021

View reviewed changes

minizip-ng: Apply suggestions

7b91f12

This comment has been minimized.

Sign in to view

prince-chrismc reviewed Jan 28, 2021

View reviewed changes

minizip-ng: Fix

6b4316e

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Jan 29, 2021

minizip-ng: Fix

9d9ee40

conan-center-bot removed the Failed label Jan 29, 2021

uilianries reviewed Jan 29, 2021

View reviewed changes

conan-center-bot added the Failed label Mar 7, 2021

stale bot added the stale label Apr 6, 2021

uilianries mentioned this pull request Apr 9, 2021

Add minizip-ng 3.0.1 #5166

Merged

4 tasks

ghost mentioned this pull request Apr 9, 2021

[service] Potentially conflicting recipes #3571

Closed

conan-center-bot closed this in #5166 May 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

minizip-ng: Add 3.0.0 #4394

minizip-ng: Add 3.0.0 #4394

intelligide commented Jan 28, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

uilianries Jan 28, 2021

prince-chrismc Jan 28, 2021

uilianries Jan 29, 2021

This comment has been minimized.

prince-chrismc left a comment

prince-chrismc Jan 28, 2021

prince-chrismc Jan 28, 2021

This comment has been minimized.

conan-center-bot commented Jan 29, 2021

uilianries Jan 29, 2021

Nekto89 commented Jan 29, 2021

conan-center-bot commented Mar 7, 2021

stale bot commented Apr 6, 2021

	self._cmake.definitions["MZ_LIBCOMP"] = tools.is_apple_os(self.settings.os) and self.options.with_libcomp
	self._cmake.definitions["MZ_LIBCOMP"] = tools.is_apple_os(self.settings.os) and self.options.with_libcomp

minizip-ng: Add 3.0.0 #4394

minizip-ng: Add 3.0.0 #4394

Conversation

intelligide commented Jan 28, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

uilianries Jan 28, 2021

Choose a reason for hiding this comment

prince-chrismc Jan 28, 2021

Choose a reason for hiding this comment

uilianries Jan 29, 2021

Choose a reason for hiding this comment

This comment has been minimized.

prince-chrismc left a comment

Choose a reason for hiding this comment

prince-chrismc Jan 28, 2021

Choose a reason for hiding this comment

prince-chrismc Jan 28, 2021

Choose a reason for hiding this comment

This comment has been minimized.

conan-center-bot commented Jan 29, 2021

uilianries Jan 29, 2021

Choose a reason for hiding this comment

Nekto89 commented Jan 29, 2021

conan-center-bot commented Mar 7, 2021

stale bot commented Apr 6, 2021