Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geographiclib: add precision and tools options #4295

Merged

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 18, 2021

Specify library name and version: geographiclib/all

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

There is also a POC with executables imported targets.

Official targets are:

  • lib: GeographicLib and GeographicLib::GeographicLib (2 abstractions of the same lib actually)
  • executables:
    • CartConvert and GeographicLib::CartConvert
    • ConicProj and GeographicLib::ConicProj
    • etc

partial support (float and double only)
extended, quadruple and variable values require more love
@conan-center-bot
Copy link
Collaborator

Some configurations of 'geographiclib/1.50.1' failed in build 1 (815254d31f7f345688a7d6c18e58c8c6b2146cd0):

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 18, 2021

dyld: Library not loaded: libGeographic.19.dylib
  Referenced from: /Users/jenkins/w/cci_PR-4295@2/.conan/data/geographiclib/1.50.1/_/_/package/cfb1b02dfd49b8aae4c954af3cc3968bdc0c6256/bin/CartConvert
  Reason: image not found

I guess some magic must be added to properties of imported targets, to add DYLD_LIBRARY_PATH

@conan-center-bot
Copy link
Collaborator

Some configurations of 'geographiclib/1.50.1' failed in build 2 (815254d31f7f345688a7d6c18e58c8c6b2146cd0):

@ghost
Copy link

ghost commented Jan 18, 2021

I detected other pull requests that are modifying geographiclib/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Jan 18, 2021
4 tasks
@conan-center-bot
Copy link
Collaborator

Some configurations of 'geographiclib/1.50.1' failed in build 3 (ac1bce3706e38216c65106db057cd8aa215b1173):

@conan-center-bot
Copy link
Collaborator

Failure in build 4 (1c4e7bfea289ccc5d679f5e615a6925c62372550):

  • geographiclib/1.50.1
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [TEST PACKAGE - NO IMPORTS() (KB-H034)] The method importsis not allowed in test_package/conanfile.py (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H034)

prince-chrismc
prince-chrismc previously approved these changes Jan 20, 2021
add non namespaced imported lib target
add namespaced and non-namespaced imported executable targets
@SpaceIm SpaceIm force-pushed the feature/geographiclib-precision-tools branch from 1c4e7bf to 29c718c Compare January 21, 2021 12:00
@SpaceIm SpaceIm changed the title geographiclib: add precision and tools options + provide all official CMake imported targets geographiclib: add precision and tools options Jan 21, 2021
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 21, 2021

I've removed experimental imported executables targets, it will very likely be implemented in a new conan version.

@conan-center-bot
Copy link
Collaborator

All green in build 6 (0f018ecf8345b2c34dcd7a6bb9fda22b12d021bf)! 😊

@conan-center-bot conan-center-bot merged commit 4541b81 into conan-io:master Jan 22, 2021
@SpaceIm SpaceIm deleted the feature/geographiclib-precision-tools branch January 22, 2021 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants