-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#4248) fix in CPR with WinSSL #4255
Conversation
Some configurations of 'cpr/1.3.0' failed in build 2 (
|
I'm not sure what's the right approach to solve this. Should I just patch CPR v1.3's CMakeLists.txt to add something like |
😖 There's no error in the logs cpr/1.3.0 (test package): Running test()
----Running------
> bin\test_package
-----------------
status code: 200
headers: application/json; charset=utf-8
text: {
"userId": 1,
"id": 1,
"title": "delectus aut autem",
"completed": false
} |
close the PR wait 10s and re-open... let's see if it was random 🤞 |
Some configurations of 'cpr/1.4.0' failed in build 3 (
|
It fixed v1.3.0 but now v1.4.0 is broken, that seems random indeed ;) |
No I think the order might be inconsistent, it tries to do as many versions at once, it's just reporting the first failure It might be related to https://github.com/conan-io/conan-center-index/pull/4255/files#diff-aead6257abe8f2d3a654ab6c01f99d3205fea85e598215f04953b3193f6c0b87R106-R107 being moved 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's try to revert some changes... I think the new method is a little too new
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
🤞 |
I tried removing |
CCI has issues at times... when theres no message from the bot. Your best best is to restart CI You can open close... rename title or edit the top level comment |
All green in build 8 (
|
Specify library name and version: cpr/1.5.2
Here is the pull request that follows issue #4248
I moved the validation code to the
validate()
method. Not sure If I got it right though.conan-center hook activated.