Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#4248) fix in CPR with WinSSL #4255

Merged
merged 4 commits into from
Jan 21, 2021
Merged

Conversation

rdeterre
Copy link
Contributor

Specify library name and version: cpr/1.5.2

Here is the pull request that follows issue #4248

I moved the validation code to the validate() method. Not sure If I got it right though.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2021

CLA assistant check
All committers have signed the CLA.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cpr/1.3.0' failed in build 2 (7369a312f801bd91968408fa240d9a6889f421d2):

@rdeterre
Copy link
Contributor Author

I'm not sure what's the right approach to solve this. Should I just patch CPR v1.3's CMakeLists.txt to add something like set(ignored ${CMAKE_EXPORT_NO_PACKAGE_REGISTRY})?

@prince-chrismc
Copy link
Contributor

😖 There's no error in the logs

cpr/1.3.0 (test package): Running test()

----Running------
> bin\test_package
-----------------
status code: 200
headers:     application/json; charset=utf-8
text:        {
  "userId": 1,
  "id": 1,
  "title": "delectus aut autem",
  "completed": false
}

@prince-chrismc
Copy link
Contributor

close the PR wait 10s and re-open... let's see if it was random 🤞

@rdeterre rdeterre closed this Jan 16, 2021
@rdeterre rdeterre reopened this Jan 16, 2021
@conan-center-bot
Copy link
Collaborator

Some configurations of 'cpr/1.4.0' failed in build 3 (7369a312f801bd91968408fa240d9a6889f421d2):

@rdeterre
Copy link
Contributor Author

rdeterre commented Jan 16, 2021

It fixed v1.3.0 but now v1.4.0 is broken, that seems random indeed ;)

@prince-chrismc
Copy link
Contributor

No I think the order might be inconsistent, it tries to do as many versions at once, it's just reporting the first failure

#4261

It might be related to https://github.com/conan-io/conan-center-index/pull/4255/files#diff-aead6257abe8f2d3a654ab6c01f99d3205fea85e598215f04953b3193f6c0b87R106-R107 being moved 🤔

Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try to revert some changes... I think the new method is a little too new

recipes/cpr/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cpr/all/conanfile.py Outdated Show resolved Hide resolved
rdeterre and others added 2 commits January 16, 2021 13:26
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@prince-chrismc
Copy link
Contributor

🤞

@rdeterre
Copy link
Contributor Author

I tried removing validate() completely but the build still breaks. I can't see the details of the error, but is there anything I can try to fix this?

@prince-chrismc
Copy link
Contributor

CCI has issues at times... when theres no message from the bot. Your best best is to restart CI

You can open close... rename title or edit the top level comment

@rdeterre rdeterre closed this Jan 18, 2021
@rdeterre rdeterre reopened this Jan 18, 2021
@conan-center-bot
Copy link
Collaborator

All green in build 8 (a91013f92f6169f52d446ddc6319febe3a248551)! 😊

@SSE4 SSE4 requested a review from uilianries January 19, 2021 05:38
@conan-center-bot conan-center-bot merged commit 1b115e4 into conan-io:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants