libsass: add mingw support and pure C consumer + del fPIC if shared + early checks in configure() + explicit pkg_config name #4240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validate() requires conan >=1.32.0
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
SpaceIm
changed the title
for tools.remove_files_by_mask()
ericLemanissier
previously approved these changes
Jan 13, 2021
|
All green in build 3 (
|
mathbunnyru
previously approved these changes
Jan 13, 2021
libsass is a C++ library with C API
SpaceIm
dismissed stale reviews from mathbunnyru and ericLemanissier
via
48df449
SpaceIm
changed the title
mathbunnyru
approved these changes
Jan 13, 2021
|
All green in build 4 (
|
ericLemanissier
approved these changes
Jan 13, 2021
SSE4
reviewed
Jan 13, 2021
| tools.rmdir(os.path.join(self.package_folder, "lib", "pkgconfig")) | ||
| tools.remove_files_by_mask(self.package_folder, "*.la") | ||
|
|
||
| def _install_mingw(self): | ||
| self.copy("*.h", dst="include", src=os.path.join(self._source_subfolder, "include")) |
There was a problem hiding this comment.
so, make install doesn't work for MinGW?
There was a problem hiding this comment.
Generally speaking, it should work, but install target calls something that didn't work on my computer (maybe a shell, so it can't work without msys2, not sure). Moreover it installs runtime in lib folder, so it's just easier to manually copy these files.
SSE4
approved these changes
Jan 13, 2021
prince-chrismc
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: libsass/all
conan-center hook activated.