feat: add basic rocksdb package #410

gocarlos · 2019-11-29T21:13:42Z

Specify library name and version: rocksdb/6.4.6

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

conan-center-bot · 2019-11-29T21:19:49Z

Some configurations of 'rocksdb/6.4.6' have failed:

Linux x86_64, Release, gcc 5, libstdc++ . Options: rocksdb:shared-True
- Hooks errors detected:
  - [HOOK - conan-center.py] pre_export(): ERROR: [CONAN CENTER INDEX URL (KB-H027)] The attribute 'url' should point to: https://github.com/conan-io/conan-center-index (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H027)
- Log download
- Log error Download
- Profile
Access to all the logs

recipes/rocksdb/all/CMakeLists.txt

recipes/rocksdb/all/conanfile.py

uilianries · 2019-11-29T22:03:47Z

There are some requirements which can solved by Conan: https://github.com/facebook/rocksdb/blob/master/CMakeLists.txt#L54

conan-center-bot · 2019-11-30T09:24:31Z

Some configurations of 'rocksdb/6.4.6' have failed:

Linux x86_64, Release, gcc 5, libstdc++ . Options: rocksdb:shared-True
Access to all the logs

conan-center-bot · 2019-11-30T09:25:47Z

Some configurations of 'rocksdb/6.4.6' have failed:

Linux x86_64, Release, gcc 5, libstdc++ . Options: rocksdb:shared-True
Access to all the logs

gocarlos · 2019-11-30T09:48:27Z

There are some requirements which can solved by Conan: https://github.com/facebook/rocksdb/blob/master/CMakeLists.txt#L54

done

conan-center-bot · 2019-11-30T09:53:55Z

Some configurations of 'rocksdb/6.4.6' have failed:

Linux x86_64, Release, gcc 5, libstdc++ . Options: rocksdb:shared-True
Access to all the logs

conan-center-bot · 2019-11-30T13:46:06Z

Some configurations of 'rocksdb/6.4.6' have failed:

Linux x86_64, Release, gcc 5, libstdc++ . Options: rocksdb:shared-True
Access to all the logs

conan-center-bot · 2019-11-30T16:03:16Z

Some configurations of 'rocksdb/6.4.6' have failed:

Linux x86_64, Release, gcc 5, libstdc++ . Options: rocksdb:shared-True
Access to all the logs

conan-center-bot · 2019-12-03T06:30:11Z

Some configurations of 'rocksdb/6.4.6' have failed:

Linux x86_64, Release, gcc 5, libstdc++ . Options: rocksdb:shared-True
- Hooks errors detected:
  - [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] The conan-center repository doesn't allow the packages to contain CMake find modules or config files. The packages have to be located using generators and the declared cpp_infoinformation (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H016)
  - [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] Found files:
- Log download
- Log error Download
- Profile
Access to all the logs

conan-center-bot · 2019-12-03T07:28:02Z

Some configurations of 'rocksdb/6.4.6' have failed:

Linux x86_64, Release, gcc 5, libstdc++ . Options: rocksdb:shared-True
Access to all the logs

uilianries · 2019-12-06T12:55:14Z

recipes/rocksdb/all/conanfile.py

+        cmake.definitions["WITH_ZLIB"] = self.options.with_zlib
+        cmake.definitions["WITH_ZSTD"] = self.options.with_zstd
+        # not available yet in CCI
+        cmake.definitions["WITH_JEMALLOC"] = False


I've start an effort to package this one. It builds fine on Linux, but on Windows is a nightmare.

uilianries

@gocarlos please take a look: gocarlos#1

conan-center-bot · 2019-12-07T11:48:17Z

Some configurations of 'rocksdb/6.4.6' have failed:

Windows x86_64, Debug, Visual Studio 14, MTd. Options: rocksdb:shared-False
Access to all the logs

gocarlos · 2019-12-10T15:09:02Z

@uilianries I do not have access to a windows machine, so cannot really test the windows build. eventually you can test this 👍

conan-center-bot · 2019-12-10T15:19:22Z

Some configurations of 'rocksdb/6.4.6' have failed:

Windows x86_64, Debug, Visual Studio 14, MTd. Options: rocksdb:shared-False
Access to all the logs

uilianries · 2019-12-11T19:19:17Z

@gocarlos I tested on Windows, it's falling to build build as shared lib. I'll revisit this week, it seems be an upstream bug

gocarlos · 2019-12-17T14:53:47Z

@uilianries any updates?

uilianries · 2019-12-18T17:26:05Z

@gocarlos gocarlos#2

conan-center-bot · 2019-12-18T19:17:50Z

Sorry, the system is under maintenance and it doesn't accept builds right now. Thanks for your understanding and help with the EAP program!

conan-center-bot · 2019-12-19T13:53:16Z

Some configurations of 'rocksdb/6.5.2' have failed:

Linux x86_64, Release, gcc 5, libstdc++ . Options: rocksdb:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 14, MTd. Options: rocksdb:shared-False
Access to all the logs

Signed-off-by: Uilian Ries <uilianries@gmail.com>

https://github.com/facebook/rocksdb/wiki/Building-on-Windows Signed-off-by: Uilian Ries <uilianries@gmail.com>

uilianries · 2019-12-26T19:38:29Z

@gocarlos I think this new PR will fix all those errors: gocarlos#3

Happy holidays!

conan-center-bot · 2019-12-31T16:44:28Z

Some configurations of 'rocksdb/6.5.2' have failed:

Windows x86_64, Release, Visual Studio 15, MD. Options: rocksdb:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MT. Options: rocksdb:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MDd. Options: rocksdb:shared-False
Access to all the logs
Linux x86_64, Debug, gcc 6, libstdc++11 . Options: rocksdb:shared-True
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MTd. Options: rocksdb:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MD. Options: rocksdb:shared-True
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MDd. Options: rocksdb:shared-True
Access to all the logs

uilianries · 2019-12-31T17:06:03Z

Interesting, I can't reproduce such error on Windows.

danimtb · 2020-01-03T16:49:43Z

Is this PR blocked by something else? @gocarlos

gocarlos · 2020-01-03T17:06:00Z

R blocked by something

this works on my side, though I can only test on linux, as I do not have a windows system...
@uilianries was debugging the shared lib issues on windows...

I think we could also just prevent the shared lib issues on windows for now and merge this, should work on linux/mac/windows as static lib and on linux/mac as shared lib

danimtb · 2020-01-03T17:09:20Z

I am ok with that approach if handle it rains invalid configurations. At least having the recipe for linux and mac will more than nothing and anyone can work on the windows issue if needed

gocarlos · 2020-01-03T17:17:23Z

I am ok with that approach if handle it rains invalid configurations. At least having the recipe for linux and mac will more than nothing and anyone can work on the windows issue if needed

can someone from the conan team do those smaller changes? is probably the fastest way to get it done. I guess the static lib under windows work well, its only the shared lib that makes issues

conan-center-bot · 2020-01-06T11:34:09Z

Some configurations of 'rocksdb/6.5.2' have failed:

Windows x86_64, Release, Visual Studio 15, MD. Options: rocksdb:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MT. Options: rocksdb:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MDd. Options: rocksdb:shared-False
Access to all the logs
Linux x86_64, Debug, gcc 6, libstdc++11 . Options: rocksdb:shared-True
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MTd. Options: rocksdb:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MD. Options: rocksdb:shared-True
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MDd. Options: rocksdb:shared-True
Access to all the logs

danimtb · 2020-01-08T08:09:23Z

@gocarlos cannot help you with those configurations right now. We can wait for @uilianries help or just set the invalid configuration in place for the moment. Sorry

conan-center-bot · 2020-01-17T21:48:44Z

Some configurations of 'rocksdb/6.5.2' failed in build 19 (6ed936567430e9849adaafc7f674a808ba51f619):

Windows x86_64, Release, Visual Studio 15, MD. Options: rocksdb:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MT. Options: rocksdb:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MDd. Options: rocksdb:shared-False
Access to all the logs
Linux x86_64, Debug, gcc 6, libstdc++11 . Options: rocksdb:shared-True
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MTd. Options: rocksdb:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MD. Options: rocksdb:shared-True
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MDd. Options: rocksdb:shared-True
Access to all the logs

gocarlos · 2020-03-02T23:18:01Z

recipes/rocksdb/all/conanfile.py

+        if self.options.with_zstd:
+            self.requires("zstd/1.3.8")
+        if self.options.with_tbb:
+            self.requires("tbb/2019_u9")


I think this recipe also depends on folly: e.g. #920

see https://github.com/facebook/rocksdb/tree/master/third-party

CLAassistant · 2020-03-05T22:26:32Z

All committers have signed the CLA.

conan-center-bot · 2020-03-09T11:47:43Z

Some configurations of 'rocksdb/6.6.4' failed in build 21 (480ce169500a809941c14da31d28ea6201603125):

Linux x86_64, Release, gcc 5, libstdc++ . Options: rocksdb:shared-True
- Hooks errors detected:
  - [HOOK - conan-center.py] pre_export(): ERROR: [NO TARGET NAME (KB-H040)] CCI uses the name of the package for cmake generator. Use 'cpp_info.names' instead. (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H040)
- Log download
- Log error Download
- Profile
Access to all the logs

conan-center-bot · 2020-03-09T12:10:03Z

Some configurations of 'rocksdb/6.6.4' failed in build 22 (0a4ed7062222cf976d5bc4001c532edbdbdcc7f6):

Linux x86_64, Release, gcc 5, libstdc++ . Options: rocksdb:shared-True
Access to all the logs

conan-center-bot · 2020-03-09T14:16:59Z

Some configurations of 'rocksdb/20200307' failed in build 24 (cd2f8fdb9bd403497b4781abc91dd5d4a08a96c8):

Linux x86_64, Debug, gcc 6, libstdc++11 . Options: rocksdb:shared-False
Access to all the logs
Linux x86_64, Debug, gcc 6, libstdc++11 . Options: rocksdb:shared-True
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MD. Options: rocksdb:shared-True
Access to all the logs

gocarlos · 2020-03-09T14:21:01Z

@uilianries the cmake file on rocksdb master is now fixed/better for shared libs etc.

uilianries · 2020-03-09T21:24:43Z

@gocarlos CI test failed due a sigabort:

rocksdb/20200307 (test package): Running test()
pure virtual method called
pure virtual method called
terminate called without an active exception
Aborted (core dumped)

gocarlos · 2020-03-18T19:06:24Z

@gocarlos CI test failed due a sigabort:

rocksdb/20200307 (test package): Running test()
pure virtual method called
pure virtual method called
terminate called without an active exception
Aborted (core dumped)

yes, have no idea why this happens here

conan-center-bot · 2020-03-18T19:51:49Z

Some configurations of 'rocksdb/20200307' failed in build 25 (c0658b2fdbb65a5a322f942225336eba89a40c70):

Linux x86_64, Debug, gcc 6, libstdc++11 . Options: rocksdb:shared-False
Access to all the logs
Linux x86_64, Debug, gcc 6, libstdc++11 . Options: rocksdb:shared-True
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MD. Options: rocksdb:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MD. Options: rocksdb:shared-True
Access to all the logs

gocarlos · 2020-03-20T08:17:00Z

@uilianries can you have a look? On my side it works all

conan-center-bot added the Failed label Nov 29, 2019

gocarlos mentioned this pull request Nov 29, 2019

RocksDB/5.8 conan-io/wishlist#92

Closed

uilianries requested changes Nov 29, 2019

View reviewed changes

recipes/rocksdb/all/CMakeLists.txt Outdated Show resolved Hide resolved

recipes/rocksdb/all/conanfile.py Outdated Show resolved Hide resolved

recipes/rocksdb/all/conanfile.py Outdated Show resolved Hide resolved

recipes/rocksdb/all/conanfile.py Outdated Show resolved Hide resolved

gocarlos force-pushed the master branch from 802a8cf to 03d3556 Compare December 3, 2019 06:14

uilianries reviewed Dec 6, 2019

View reviewed changes

uilianries mentioned this pull request Dec 18, 2019

[request] libnuma/2.0.13 #508

Closed

uilianries closed this Dec 19, 2019

uilianries reopened this Dec 19, 2019

uilianries added a commit to uilianries/conan-center-index that referenced this pull request Dec 26, 2019

conan-io#410 fPIC is true by default

5c33170

Signed-off-by: Uilian Ries <uilianries@gmail.com>

uilianries added a commit to uilianries/conan-center-index that referenced this pull request Dec 26, 2019

conan-io#410 Rocksdb requires msvc15 at least

ae454cd

https://github.com/facebook/rocksdb/wiki/Building-on-Windows Signed-off-by: Uilian Ries <uilianries@gmail.com>

uilianries closed this Dec 31, 2019

uilianries reopened this Dec 31, 2019

danimtb assigned gocarlos Jan 3, 2020

gocarlos closed this Jan 6, 2020

gocarlos reopened this Jan 6, 2020

gocarlos mentioned this pull request Jan 8, 2020

[request] some of most relevant c++ libraries in github (by number of stars) #621

Open

gocarlos removed their assignment Jan 13, 2020

gocarlos commented Mar 2, 2020

View reviewed changes

gocarlos mentioned this pull request Mar 9, 2020

Use BUILD_SHARED_LIBS to set lib type in CMake facebook/rocksdb#4972

Closed

gocarlos mentioned this pull request Apr 17, 2020

add rocksdb 6.8.1 #1389

Merged

4 tasks

gocarlos closed this Apr 19, 2020

gocarlos force-pushed the master branch from c0658b2 to db48f74 Compare April 19, 2020 13:03

feat: add basic rocksdb package #410

feat: add basic rocksdb package #410

Conversation

gocarlos commented Nov 29, 2019

conan-center-bot commented Nov 29, 2019

uilianries commented Nov 29, 2019

conan-center-bot commented Nov 30, 2019

conan-center-bot commented Nov 30, 2019

gocarlos commented Nov 30, 2019

conan-center-bot commented Nov 30, 2019

conan-center-bot commented Nov 30, 2019

conan-center-bot commented Nov 30, 2019

conan-center-bot commented Dec 3, 2019

conan-center-bot commented Dec 3, 2019

uilianries Dec 6, 2019

Choose a reason for hiding this comment

uilianries left a comment

Choose a reason for hiding this comment

conan-center-bot commented Dec 7, 2019

gocarlos commented Dec 10, 2019

conan-center-bot commented Dec 10, 2019

uilianries commented Dec 11, 2019

gocarlos commented Dec 17, 2019

uilianries commented Dec 18, 2019

conan-center-bot commented Dec 18, 2019

conan-center-bot commented Dec 19, 2019

uilianries commented Dec 26, 2019

conan-center-bot commented Dec 31, 2019

uilianries commented Dec 31, 2019

danimtb commented Jan 3, 2020

gocarlos commented Jan 3, 2020

danimtb commented Jan 3, 2020

gocarlos commented Jan 3, 2020

conan-center-bot commented Jan 6, 2020

danimtb commented Jan 8, 2020

conan-center-bot commented Jan 17, 2020

gocarlos Mar 2, 2020

Choose a reason for hiding this comment

CLAassistant commented Mar 5, 2020

conan-center-bot commented Mar 9, 2020

conan-center-bot commented Mar 9, 2020

conan-center-bot commented Mar 9, 2020

gocarlos commented Mar 9, 2020

uilianries commented Mar 9, 2020

gocarlos commented Mar 18, 2020

conan-center-bot commented Mar 18, 2020

gocarlos commented Mar 20, 2020