Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gperf] Patch gperf to remove register storage classifier (deprecated in C++17) #3876

Closed

Conversation

daravi
Copy link
Contributor

@daravi daravi commented Dec 13, 2020

Specify library name and version: gperf/3.1

I will open patch request upstream time permitting. The register storage specifier does not compile in newer versions of Clang.

  • [✓] I've read the guidelines for contributing.
  • [✓] I've followed the PEP8 style guides for Python code in the recipes.
  • [✓] I've used the latest Conan client version.
  • [✓] I've tried at least one configuration locally with the
    conan-center hook activated.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Puya Daravi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@conan-center-bot
Copy link
Collaborator

Failure in build 1 (4c20d3cfaa8a8bc5beb133189207501d302e17cd):

  • gperf/3.1
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [NO FINAL ENDLINE (KB-H041)] File '/home/conan/w/cci_PR-3876/recipes/gperf/all/conandata.yml' does not end with an endline (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H041)

Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3903

https://git.savannah.gnu.org/gitweb/?p=gperf.git;a=commitdiff;h=a63b830554920476881837eeacd4a6b507632b19;hp=313d1a67708737cab0e917ac4064cb39a167e794

Seems this was already applied upstream

Perhaps it's better to add a new "virtual release" that includes this fix? Seems there a few other bug fixes that would be beneficial to add

@daravi
Copy link
Contributor Author

daravi commented Dec 22, 2020

@prince-chrismc That's a good idea since there hasn't been an official release for 2 years. But should we still keep the 3.1 patch in? Otherwise all dependent recipes will be broken in a fully complaint c++17 compiler like Clang 10.0.1 and newer unless they alos use the cci release.

@prince-chrismc
Copy link
Contributor

Anyone using the 3.1 release will expect it to be broken, right? So dependant projects would not support C++17... It would be very surprising when it's magically working from CCI.

#3476 is an example where the consumer got a nasty surprise.

This topic is open for discussion, so feel free to add your thoughts to the issue of PR

@stale
Copy link

stale bot commented Jan 21, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@daravi
Copy link
Contributor Author

daravi commented Jan 28, 2021

Perhaps it's better to add a new "virtual release" that includes this fix? Seems there a few other bug fixes that would be beneficial to add

That makes sense. I might not have time to do it now but I will try to do it soon.

@stale stale bot removed the stale label Jan 28, 2021
@prince-chrismc
Copy link
Contributor

I tried quickly #4332 if you want a head start

@ghost
Copy link

ghost commented Feb 2, 2021

I detected other pull requests that are modifying gperf/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@stale
Copy link

stale bot commented Mar 4, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 4, 2021
@conan-center-bot
Copy link
Collaborator

Failure in build 2 (4c20d3cfaa8a8bc5beb133189207501d302e17cd):

  • gperf/3.1@:
    Error running command conan export "recipes/gperf/all/conanfile.py" gperf/3.1@:
    [HOOK - conan-center.py] pre_export(): [DEPRECATED GLOBAL CPPSTD (KB-H001)] OK
    [HOOK - conan-center.py] pre_export(): [REFERENCE LOWERCASE (KB-H002)] OK
    [HOOK - conan-center.py] pre_export(): [RECIPE METADATA (KB-H003)] OK
    [HOOK - conan-center.py] pre_export(): [HEADER_ONLY, NO COPY SOURCE (KB-H005)] OK
    [HOOK - conan-center.py] pre_export(): [FPIC OPTION (KB-H006)] OK
    [HOOK - conan-center.py] pre_export(): [VERSION RANGES (KB-H008)] OK
    [HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] Total recipe size: 4.5068359375 KB
    [HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] OK
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: ['patches/*']
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE FOLDER (KB-H024)] OK
    [HOOK - conan-center.py] pre_export(): [META LINES (KB-H025)] OK
    [HOOK - conan-center.py] pre_export(): [CONAN CENTER INDEX URL (KB-H027)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE MINIMUM VERSION (KB-H028)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE - RUN ENVIRONMENT (KB-H029)] OK
    [HOOK - conan-center.py] pre_export(): [SYSTEM REQUIREMENTS (KB-H032)] OK
    [HOOK - conan-center.py] pre_export(): [CONANDATA.YML FORMAT (KB-H030)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO IMPORTS() (KB-H034)] OK
    [HOOK - conan-center.py] pre_export(): [NO AUTHOR (KB-H037)] OK
    [HOOK - conan-center.py] pre_export(): [NO TARGET NAME (KB-H040)] OK
    [HOOK - conan-center.py] pre_export(): [NO REQUIRES.ADD() (KB-H044)] OK
    [HOOK - conan-center.py] pre_export(): [DELETE OPTIONS (KB-H045)] OK
    [HOOK - conan-center.py] pre_export(): [NO ASCII CHARACTERS (KB-H047)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE VERBOSE MAKEFILE (KB-H046)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE VERSION REQUIRED (KB-H048)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE WINDOWS EXPORT ALL SYMBOLS (KB-H049)] OK
    [HOOK - conan-center.py] pre_export(): [DEFAULT OPTIONS AS DICTIONARY (KB-H051)] OK
    [HOOK - conan-center.py] pre_export(): [CONFIG.YML HAS NEW VERSION (KB-H052)] OK
    [HOOK - conan-center.py] pre_export(): [PRIVATE IMPORTS (KB-H053)] OK
    [HOOK - conan-center.py] pre_export(): [SINGLE REQUIRES (KB-H055)] OK
    [HOOK - conan-center.py] pre_export(): ERROR: [NO FINAL ENDLINE (KB-H041)] File '/home/conan/w/cci_PR-3876/recipes/gperf/all/conandata.yml' does not end with an endline (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H041) 
    ERROR: [HOOK - conan-center.py] pre_export(): Some checks failed running the hook, check the output
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@stale stale bot removed the stale label Mar 7, 2021
@stale
Copy link

stale bot commented Apr 6, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 6, 2021
@stale
Copy link

stale bot commented May 6, 2021

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this May 6, 2021
@daravi daravi deleted the gperf-remove_register_classifier branch July 7, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants