-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gperf] Patch gperf to remove register storage classifier (deprecated in C++17) #3876
Conversation
Puya Daravi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Failure in build 1 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems this was already applied upstream
Perhaps it's better to add a new "virtual release" that includes this fix? Seems there a few other bug fixes that would be beneficial to add
@prince-chrismc That's a good idea since there hasn't been an official release for 2 years. But should we still keep the 3.1 patch in? Otherwise all dependent recipes will be broken in a fully complaint c++17 compiler like Clang 10.0.1 and newer unless they alos use the cci release. |
Anyone using the 3.1 release will expect it to be broken, right? So dependant projects would not support C++17... It would be very surprising when it's magically working from CCI. #3476 is an example where the consumer got a nasty surprise. This topic is open for discussion, so feel free to add your thoughts to the issue of PR |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
That makes sense. I might not have time to do it now but I will try to do it soon. |
I tried quickly #4332 if you want a head start |
I detected other pull requests that are modifying gperf/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Failure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Specify library name and version: gperf/3.1
I will open patch request upstream time permitting. The
register
storage specifier does not compile in newer versions of Clang.conan-center hook activated.