Embree 3.12.0 recipe #354

KaoCC · 2019-11-18T22:14:28Z

Specify library name and version: embree/3.12.0

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

Note:
closes #343
tested on local machine with the following compiler: GCC 5.5.0 , Apple Clang 12.0.0

CLAassistant · 2019-11-18T22:14:54Z

All committers have signed the CLA.

recipes/embree/all/conanfile.py

conan-center-bot · 2019-11-18T23:11:03Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

recipes/embree/all/conanfile.py

uilianries · 2019-11-19T01:35:42Z

Hi @KaoCC !

Thanks for your PR! Please, take a look on my comments/review.

recipes/embree/all/conanfile.py

KaoCC · 2019-11-19T19:46:50Z

thanks all, I will address these comments in the following commit

conan-center-bot · 2019-11-19T20:41:20Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

KaoCC

thank you very much ! I addressed them in the following commit.

conan-center-bot · 2019-11-20T11:12:44Z

All green! 😊

embree/3.6.1: Generated 1 packages. All logs here

uilianries · 2019-11-20T12:28:27Z

recipes/embree/all/conanfile.py

+        "backface_culling": False,
+        "ignore_invalid_rays": False,
+        "ray_masking": False,
+        "tbb:tbbmalloc": True,


As Embree requires this specific option and currently we don't have this package available, we will or remove this option, or provide such configuration as pre-built package.

How would you suggest to do that ? Wouldn't that cause the Embree build to fail if that option is required but removed?

@uilianries Thanks for your comment, would you please provide any guidance of how this PR could proceed ? Is there any change could be made on my side ? 😃

It's a good question. We have similar situation for header-only recipes. We need to provide some option for these cases. @danimtb WDYT ?

Well I thought if the tbb package with that specific option is missing one can simply build it with --build missing setting. That's how I did on my dev machine.

@KaoCC does this package really need that option of tbb activated? Can you try removing "tbb:tbbmalloc": True, and see what happens? Thanks

@danimtb ... strange. I just tested it on two distinct machines and it seems like it will also compiled without the flag. I recalled the flag was a requirement. Anyway I removed it and pushed the commit again.

conan-center-bot · 2019-11-25T17:30:01Z

Some configurations of 'embree/3.6.1' have failed:

Linux x86_64, Release, gcc 5, libstdc++ . Options: embree:shared-True
Access to all the logs

KaoCC · 2019-11-25T19:49:02Z

Now it says : ERROR: Missing prebuilt package for 'tbb/2019_u9'
Try to build it from sources with "--build tbb"

danimtb · 2019-11-26T10:01:57Z

Yes, sorry about that.

I don't know why the error did not show up before. This is the expected behavior for a requirement that has a missing package.

Unfortunately, the feature to support specific options will not be immediate but we will prioritize it

uilianries

in terms of quality the recipe looks good, but the ci is failing

danimtb · 2019-12-13T10:27:06Z

Seems the tbb option is required for Mac at least:

embree/3.6.1: Calling build()
-- The C compiler identification is AppleClang 9.1.0.9020039
-- The CXX compiler identification is AppleClang 9.1.0.9020039
-- Check for working C compiler: /Applications/Xcode-9.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
-- Check for working C compiler: /Applications/Xcode-9.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /Applications/Xcode-9.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
-- Check for working CXX compiler: /Applications/Xcode-9.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Conan: called by CMake conan helper
-- Conan: called inside local cache
-- Conan: Adjusting output directories
-- Conan: Using cmake global configuration
-- Conan: Adjusting default RPATHs Conan policies
-- Conan: Adjusting language standard
-- Conan: Adjusting fPIC flag (ON)
-- Conan: C++ stdlib: libc++
CMake Error at /usr/local/Cellar/cmake/3.14.1/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:137 (message):  Could NOT find TBB (missing: TBB_LIBRARY TBB_LIBRARY_MALLOC)
Call Stack (most recent call first):  /usr/local/Cellar/cmake/3.14.1/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)  source_subfolder/common/cmake/FindTBB.cmake:140 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)  source_subfolder/CMakeLists.txt:468 (FIND_PACKAGE)


-- Configuring incomplete, errors occurred!

conan-center-bot · 2019-12-13T11:14:37Z

Some configurations of 'embree/3.6.1' have failed:

Macos x86_64, Debug, apple-clang 9.1, libc++ . Options: embree:shared-True
Access to all the logs
Windows x86_64, Debug, Visual Studio 14, MTd. Options: embree:shared-False
Access to all the logs

conan-center-bot · 2019-12-20T11:22:30Z

Some configurations of 'embree/3.6.1' have failed:

Macos x86_64, Debug, apple-clang 9.1, libc++ . Options: embree:shared-True
Access to all the logs
Windows x86_64, Debug, Visual Studio 14, MTd. Options: embree:shared-False
Access to all the logs

uilianries

These changes will fix the MacOS error, I checked on apple-clang 11

recipes/embree/all/conanfile.py

conan-center-bot · 2019-12-23T21:08:06Z

Some configurations of 'embree/3.6.1' have failed:

Linux x86_64, Release, gcc 5, libstdc++ . Options: embree:shared-True
Access to all the logs

uilianries · 2019-12-24T12:26:26Z

I just pushed a fix for TBB, which should solve this current error: #536

conan-center-bot · 2020-09-30T20:08:03Z

An unexpected error happened and has been reported. Help is on its way! 🏇

conan-center-bot · 2020-10-01T13:19:04Z

An unexpected error happened and has been reported. Help is on its way! 🏇

conan-center-bot · 2020-10-01T19:37:28Z

All green in build 35 (4a4af147cf8dd5ecd0ffbbdcb3031cf1a0c806dd)! 😊

embree3/3.12.0: Generated 4 packages. All logs here

recipes/embree3/all/conanfile.py

recipes/embree3/all/test_package/CMakeLists.txt

recipes/embree3/all/conanfile.py

SpaceIm · 2020-10-01T20:22:28Z

recipes/embree3/all/conanfile.py

+        cmake.install()
+        self.copy("LICENSE.txt", src=self._source_folder, dst="licenses")
+        tools.rmdir(os.path.join(self.package_folder, "share"))
+        tools.rmdir(os.path.join(self.package_folder, 'lib', 'cmake'))


What is the config filename, and imported target if any?

which config ?

the CMake config file generated in os.path.join(self.package_folder, 'lib', 'cmake')

Oh there are lots of them if I remember correctly. I can check it perhaps later.

/lib/cmake/embree-3.12.0/embree-config.cmake /lib/cmake/embree-3.12.0/embree-config-version.cmake /lib/cmake/embree-3.12.0/sys-targets.cmake /lib/cmake/embree-3.12.0/sys-targets-release.cmake /lib/cmake/embree-3.12.0/math-targets.cmake /lib/cmake/embree-3.12.0/math-targets-release.cmake /lib/cmake/embree-3.12.0/simd-targets.cmake /lib/cmake/embree-3.12.0/simd-targets-release.cmake /lib/cmake/embree-3.12.0/lexers-targets.cmake /lib/cmake/embree-3.12.0/lexers-targets-release.cmake /lib/cmake/embree-3.12.0/tasking-targets.cmake /lib/cmake/embree-3.12.0/tasking-targets-release.cmake /lib/cmake/embree-3.12.0/embree_sse42-targets.cmake /lib/cmake/embree-3.12.0/embree_sse42-targets-release.cmake /lib/cmake/embree-3.12.0/embree_avx-targets.cmake /lib/cmake/embree-3.12.0/embree_avx-targets-release.cmake /lib/cmake/embree-3.12.0/embree_avx2-targets.cmake /lib/cmake/embree-3.12.0/embree_avx2-targets-release.cmake /lib/cmake/embree-3.12.0/embree_avx512skx-targets.cmake /lib/cmake/embree-3.12.0/embree_avx512skx-targets-release.cmake /lib/cmake/embree-3.12.0/embree-targets.cmake /lib/cmake/embree-3.12.0/embree-targets-release.cmake

so self.cpp_info.names["cmake_find_package"] and self.cpp_info.names["cmake_find_package_multi"] should be embree. What are the imported targets in *-targets files?

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

conan-center-bot · 2020-10-05T14:30:21Z

An unexpected error happened and has been reported. Help is on its way! 🏇

jgsogo · 2020-10-05T14:31:27Z

An unexpected error happened and has been reported. Help is on its way! 🏇

I've just triggered it manually, I'll monitor it until it finishes... not sure what happened with the previous job.

conan-center-bot · 2020-10-05T16:34:58Z

An unexpected error happened and has been reported. Help is on its way! 🏇

conan-center-bot · 2020-10-05T16:42:39Z

All green in build 41 (147957164bb008f656754d523e4cc82ec17563f0)! 😊

embree3/3.12.0: Generated 70 packages. All logs here

ohanar · 2020-10-16T02:09:09Z

recipes/embree3/all/conanfile.py

+            tools.rmdir(os.path.join(self.package_folder, "bin"))
+
+    def package_info(self):
+        self.cpp_info.libs = tools.collect_libs(self)


From the documentation

EMBREE_STATIC_LIB: Builds Embree as a static library (OFF by default). Further multiple static libraries are generated for the different ISAs selected (e.g. embree3.a, embree3_sse42.a, embree3_avx.a, embree3_avx2.a, embree3_avx512knl.a, embree3_avx512skx.a). You have to link these libraries in exactly this order of increasing ISA.

So you can't simply collect libs.

Thank you very much. I can fix that later, or in a followup patch, when I'm available.

prince-chrismc · 2020-10-18T19:08:13Z

I am all for this being merged but there's two comments which might be worth doing in the future #354 (comment) and #354 (comment)

There are 3 approvals but the CCI bot has not merged this one in a few days

danimtb · 2020-10-19T16:05:25Z

@prince-chrismc indeed, this seems to be a bug in the automatic merge of the bot. Basically, a lot of reviews in this PR that got "hidden" by the github pagination. We are already working on a fix for it. Thank you!

prince-chrismc · 2020-10-23T22:20:05Z

Bug fixed! Awesome work 🚀

Morwenn reviewed Nov 18, 2019

View reviewed changes

recipes/embree/all/conanfile.py Outdated Show resolved Hide resolved

Morwenn reviewed Nov 18, 2019

View reviewed changes

recipes/embree/all/conanfile.py Outdated Show resolved Hide resolved

conan-center-bot added the No Beta user label Nov 18, 2019

uilianries requested changes Nov 19, 2019

View reviewed changes

Croydon reviewed Nov 19, 2019

View reviewed changes

recipes/embree/all/conanfile.py Outdated Show resolved Hide resolved

KaoCC requested a review from uilianries November 19, 2019 20:45

KaoCC commented Nov 19, 2019

View reviewed changes

danimtb removed the No Beta user label Nov 20, 2019

uilianries mentioned this pull request Nov 20, 2019

[service] CI job passed with success when package is missing #368

Closed

uilianries requested changes Nov 20, 2019

View reviewed changes

KaoCC requested a review from uilianries November 21, 2019 13:38

conan-center-bot added the Failed label Nov 25, 2019

danimtb assigned KaoCC Dec 12, 2019

uilianries reviewed Dec 13, 2019

View reviewed changes

uilianries requested changes Dec 20, 2019

View reviewed changes

recipes/embree/all/conanfile.py Outdated Show resolved Hide resolved

recipes/embree/all/conanfile.py Outdated Show resolved Hide resolved

uilianries mentioned this pull request Dec 24, 2019

Add version 2020.0 for TBB #536

Merged

4 tasks

KaoCC force-pushed the embree branch from 388a27a to 4a4af14 Compare September 30, 2020 19:46

KaoCC closed this Sep 30, 2020

KaoCC reopened this Sep 30, 2020

uilianries closed this Oct 1, 2020

uilianries reopened this Oct 1, 2020

conan-center-bot removed the Unexpected Error label Oct 1, 2020

SpaceIm suggested changes Oct 1, 2020

View reviewed changes

KaoCC and others added 3 commits October 2, 2020 01:27

Apply suggestions from code review

867c9c1

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

Update recipes/embree3/all/conanfile.py

905e85d

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

remove redundant MacOS Clang checks

1479571

conan-center-bot added the Unexpected Error label Oct 5, 2020

conan-center-bot removed the Unexpected Error label Oct 5, 2020

uilianries approved these changes Oct 6, 2020

View reviewed changes

danimtb approved these changes Oct 6, 2020

View reviewed changes

danimtb requested a review from SSE4 October 6, 2020 12:20

SSE4 approved these changes Oct 12, 2020

View reviewed changes

ohanar reviewed Oct 16, 2020

View reviewed changes

prince-chrismc approved these changes Oct 18, 2020

View reviewed changes

conan-center-bot merged commit cc30da9 into conan-io:master Oct 23, 2020

Embree 3.12.0 recipe #354

Embree 3.12.0 recipe #354

Conversation

KaoCC commented Nov 18, 2019 • edited by uilianries Loading

CLAassistant commented Nov 18, 2019 • edited Loading

conan-center-bot commented Nov 18, 2019

uilianries commented Nov 19, 2019

KaoCC commented Nov 19, 2019

conan-center-bot commented Nov 19, 2019

KaoCC left a comment

Choose a reason for hiding this comment

conan-center-bot commented Nov 20, 2019

Choose a reason for hiding this comment

KaoCC Nov 20, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conan-center-bot commented Nov 25, 2019

KaoCC commented Nov 25, 2019

danimtb commented Nov 26, 2019

uilianries left a comment

Choose a reason for hiding this comment

danimtb commented Dec 13, 2019

conan-center-bot commented Dec 13, 2019

conan-center-bot commented Dec 20, 2019

uilianries left a comment • edited Loading

Choose a reason for hiding this comment

conan-center-bot commented Dec 23, 2019

uilianries commented Dec 24, 2019

conan-center-bot commented Sep 30, 2020

conan-center-bot commented Oct 1, 2020

conan-center-bot commented Oct 1, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conan-center-bot commented Oct 5, 2020

jgsogo commented Oct 5, 2020

conan-center-bot commented Oct 5, 2020

conan-center-bot commented Oct 5, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prince-chrismc commented Oct 18, 2020

danimtb commented Oct 19, 2020

prince-chrismc commented Oct 23, 2020

KaoCC commented Nov 18, 2019 •

edited by uilianries

Loading

CLAassistant commented Nov 18, 2019 •

edited

Loading

KaoCC Nov 20, 2019 •

edited

Loading

uilianries left a comment •

edited

Loading