Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libx264/*: remove apple_deployment_target_flag #3455

Merged
merged 1 commit into from
Dec 17, 2020
Merged

libx264/*: remove apple_deployment_target_flag #3455

merged 1 commit into from
Dec 17, 2020

Conversation

MartinDelille
Copy link
Contributor

@MartinDelille MartinDelille commented Nov 8, 2020 •
edited
Loading

Minimum conan version: 1.31.0

Since apple_deployment_target_flag is set by conan since version 1.31.0 (conan-io/conan#7862), I removed this specific formula code.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@uilianries uilianries closed this Nov 11, 2020
@uilianries uilianries reopened this Nov 11, 2020
@conan-center-bot
Copy link
Collaborator

All green in build 2 (f3bedf251820663854b9aba72f721be40cc458ec)! 😊

@Croydon
Copy link
Contributor

Croydon commented Nov 12, 2020

Remember that this has to be re-build when macOS CI has Conan >= 1.31.0 and should be only merged then

SSE4
SSE4 approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less code - less bugs

@SSE4 SSE4 added the blocked Affected by an external issue and waiting until it is solved label Nov 12, 2020
@danimtb danimtb added the infrastructure Waiting on tools or services belonging to the infra label Nov 12, 2020
@uilianries
Copy link
Member

less code - less bugs

https://github.com/kelseyhightower/nocode

@ericLemanissier ericLemanissier mentioned this pull request Nov 14, 2020
Closed
@Croydon
Copy link
Contributor

Croydon commented Nov 18, 2020

Unblocked #3596

Please close, and reopen the PR again after ~10 seconds to restart CI

@danimtb danimtb removed blocked Affected by an external issue and waiting until it is solved infrastructure Waiting on tools or services belonging to the infra labels Nov 18, 2020
@danimtb
Copy link
Member

danimtb commented Nov 18, 2020

Just restarted the job

@conan-center-bot
Copy link
Collaborator

All green in build 3 (f3bedf251820663854b9aba72f721be40cc458ec)! 😊

@danimtb
Copy link
Member

danimtb commented Nov 18, 2020

ping @uilianries

@conan-center-bot conan-center-bot merged commit 4f5cff0 into conan-io:master Dec 17, 2020
@MartinDelille MartinDelille deleted the libx264-remove-apple-deployment-target-flag branch July 15, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@Croydon Croydon Croydon approved these changes

@danimtb danimtb danimtb approved these changes

@uilianries uilianries Awaiting requested review from uilianries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MartinDelille @conan-center-bot @Croydon @uilianries @danimtb @SSE4