Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libelfin: reading ELF binaries and DWARFv4 debug information #3283

Merged
merged 5 commits into from
Dec 3, 2020
Merged

libelfin: reading ELF binaries and DWARFv4 debug information #3283

merged 5 commits into from
Dec 3, 2020

Conversation

klimkin
Copy link
Contributor

@klimkin klimkin commented Oct 20, 2020

C++11 library for reading ELF binaries and DWARFv4 debug information.

Specify library name and version: libelfin/0.3

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@klimkin klimkin mentioned this pull request Oct 20, 2020
Closed
4 tasks
@conan-center-bot
Copy link
Collaborator

Some configurations of 'libelfin/0.2' failed in build 1 (0c558d067cbf2c98708e2a8931bfbfa5148db682):

@klimkin klimkin force-pushed the feature/add-libelfin branch from 0c558d0 to efe0cae Compare October 22, 2020 00:41
@conan-center-bot
Copy link
Collaborator

Some configurations of 'libelfin/0.3' failed in build 2 (efe0cae37b94c7053c4b6b4d4aa279b6e78ddfe2):

@klimkin klimkin force-pushed the feature/add-libelfin branch from efe0cae to 12184a6 Compare October 22, 2020 15:21
@conan-center-bot
Copy link
Collaborator

Some configurations of 'libelfin/0.3' failed in build 3 (12184a602c9f4a1c2fee01c00cd3ac7a6745cc5d):

@klimkin klimkin force-pushed the feature/add-libelfin branch from 12184a6 to 8005676 Compare October 22, 2020 15:46
@conan-center-bot
Copy link
Collaborator

Some configurations of 'libelfin/0.3' failed in build 4 (80056769df8fb4e5f5660dead15ce6b6dd1b4099):

@klimkin
Copy link
Contributor Author

klimkin commented Oct 22, 2020

@madebr This library requires C++11. What is the strategy to set default cppstd setting?

madebr
madebr reviewed Oct 22, 2020
View reviewed changes
recipes/libelfin/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libelfin/all/conanfile.py Outdated Show resolved Hide resolved
recipes/libelfin/all/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/libelfin/all/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/libelfin/all/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/libelfin/all/patches/946dde57e5caef8297b9339f3a7971401d540840.patch Outdated Show resolved Hide resolved
recipes/libelfin/all/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/libelfin/all/CMakeLists.txt Show resolved Hide resolved
@klimkin klimkin force-pushed the feature/add-libelfin branch from 8005676 to ef50bca Compare October 22, 2020 17:57
@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@klimkin klimkin force-pushed the feature/add-libelfin branch from ef50bca to 79c89f4 Compare October 22, 2020 19:18
@conan-center-bot
Copy link
Collaborator

Some configurations of 'libelfin/0.3' failed in build 6 (79c89f4b369333fdb0375d81e47de26748ccdd65):

@klimkin klimkin force-pushed the feature/add-libelfin branch 2 times, most recently from 27792a3 to 8a71036 Compare October 22, 2020 19:35
@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot
Copy link
Collaborator

Some configurations of 'libelfin/0.3' failed in build 8 (8a7103605af4e9e32c6d0a5a71ad6649e663efc2):

@ericLemanissier ericLemanissier mentioned this pull request Nov 12, 2020
Closed
@klimkin
Copy link
Contributor Author

klimkin commented Nov 13, 2020

@SSE4 , @uilianries Could you approve, please?

@prince-chrismc
Copy link
Contributor

@klimkin Don't forget the community reviewers we count as well! #2857

SSE4
SSE4 previously approved these changes Nov 17, 2020
View reviewed changes
@prince-chrismc
Copy link
Contributor

This PR is ready for review 😃

@madebr
@SpaceIm
@ericLemanissier
@Croydon
@intelligide
@theirix
@gocarlos

madebr
madebr previously approved these changes Dec 2, 2020
View reviewed changes
intelligide
intelligide suggested changes Dec 3, 2020
View reviewed changes
recipes/libelfin/all/conandata.yml Outdated Show resolved Hide resolved
@klimkin
libelfin: reading ELF binaries and DWARFv4 debug information
0e92ff8 
C++11 library for reading ELF binaries and DWARFv4 debug information.
intelligide
intelligide suggested changes Dec 3, 2020
View reviewed changes
recipes/libelfin/all/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/libelfin/all/conandata.yml Outdated Show resolved Hide resolved
@klimkin klimkin dismissed stale reviews from madebr, SSE4, and prince-chrismc via 1bce461 December 3, 2020 00:38
@klimkin klimkin force-pushed the feature/add-libelfin branch from 328838f to 1bce461 Compare December 3, 2020 00:38
klimkin and others added 2 commits December 2, 2020 16:43
@klimkin @intelligide
Update recipes/libelfin/all/CMakeLists.txt
3b448e6 
Co-authored-by: Yoann Potinet <intelligide@hotmail.fr>
@klimkin
Include GNUInstallDirs module
579697e
@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@klimkin @intelligide
Apply suggestions from code review
4554302 
Co-authored-by: Yoann Potinet <intelligide@hotmail.fr>
@conan-center-bot
Copy link
Collaborator

All green in build 21 (455430266e0e09aa4323e8452886fac657d3fb64)! 😊

@prince-chrismc
Copy link
Contributor

Please refrain from force pushing, it forces us to review the entire PR ... which was not my intention!

@klimkin
Copy link
Contributor Author

klimkin commented Dec 3, 2020

Please refrain from force pushing, it forces us to review the entire PR ... which was not my intention!

Sorry, I realized this too late, need to unlearn this habit.

@conan-center-bot conan-center-bot merged commit 31e3344 into conan-io:master Dec 3, 2020
@klimkin klimkin deleted the feature/add-libelfin branch January 26, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceIm SpaceIm SpaceIm requested changes

@madebr madebr madebr left review comments

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@intelligide intelligide intelligide approved these changes

@SSE4 SSE4 SSE4 approved these changes

@danimtb danimtb danimtb left review comments

@uilianries uilianries Awaiting requested review from uilianries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@klimkin @conan-center-bot @madebr @SpaceIm @prince-chrismc @SSE4 @danimtb @intelligide @uilianries