Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgfx: add msvc version 194 #25606

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

danniesim
Copy link

@danniesim danniesim commented Oct 12, 2024

Summary

Changes to recipe: bgfx/cci.20230216

Motivation

The latest version of MSVC 2022 presents as 194; there is no key to handle that number, resulting in a key error when building.

Details

Add version 194 that maps to MSVC 2022


@CLAassistant
Copy link

CLAassistant commented Oct 12, 2024

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@danniesim danniesim mentioned this pull request Oct 14, 2024
@danniesim danniesim changed the title bgfx: add vs version 194 bgfx: add msvc version 194 Oct 14, 2024
@jcar87
Copy link
Contributor

jcar87 commented Oct 14, 2024

hi @danniesim - thanks so much for this fix!
looks like you have an autoformatter enabled - would you mind pushing a commit where the actual bugfix is the only change? makes it a lot easier to review, thanks!

@AbrilRBS AbrilRBS self-assigned this Oct 14, 2024
@conan-center-bot

This comment has been minimized.

@jcar87
Copy link
Contributor

jcar87 commented Oct 14, 2024

Thanks @danniesim! - running this on CI right now :)

@AbrilRBS
Copy link
Member

Thanks! Note that we would also need you to sign the CLA for this to be mergeable, thanks!

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

Changes not allowed in build 4:

[bgfx, bimg, bx]

Only one library can be changed in the same PR.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Changes not allowed in build 4:

[bgfx, bimg, bx]

Only one library can be changed in the same PR.

@danniesim
Copy link
Author

@jcar87 @AbrilRBS Shall I split this into 3 pull requests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants