Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gn/cci.20210429: add apple arch option #25590

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Alan5142
Copy link

@Alan5142 Alan5142 commented Oct 10, 2024

Summary

Changes to recipe: gn/cci.20210429

Motivation

This PR fixes #25587. This bugfix allows the creation of binaries for other archs. The generator of gn is ignoring the arch passed when building the package.

Details

The changes involve adding arch flags to CFLAGS and LDFLAGS, allowing cross-compilation and universal binary support in macOS. They also include a change to allow passing the arch to other platforms, but the focus is on macOS.


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

Hi @Alan5142 thanks a lot for the PR

Sorry about the bot noises with the approval requirement, I'm approving these runs manually on our end until the approavl process completes, thanks for your understanding! :)

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 4 (5fd09ca2cd1af0fee96de20279bf54a697f6b837):

  • gn/cci.20240611:
    No packages built ⚠️ (All logs)

  • gn/cci.20210429:
    Built 8 packages out of 11 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (5fd09ca2cd1af0fee96de20279bf54a697f6b837):

  • gn/cci.20240611:
    No packages built ⚠️ (All logs)

  • gn/cci.20210429:
    Built 4 packages out of 5 (All logs)

@Alan5142
Copy link
Author

Hi @AbrilRBS!
No problem, thanks for taking the time. :)

@Alan5142
Copy link
Author

Alan5142 commented Oct 14, 2024

Hi @AbrilRBS,
Is there a way to check why some builds say INVALID_CONFIGURATION?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] gn/cci.20210429: Cross compiling not producing correct binary
3 participants