-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gn/cci.20210429: add apple arch option #25590
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @Alan5142 thanks a lot for the PR Sorry about the bot noises with the approval requirement, I'm approving these runs manually on our end until the approavl process completes, thanks for your understanding! :) |
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 4 (
Conan v2 pipeline ✔️
All green in build 4 ( |
Hi @AbrilRBS! |
Hi @AbrilRBS, |
Summary
Changes to recipe: gn/cci.20210429
Motivation
This PR fixes #25587. This bugfix allows the creation of binaries for other archs. The generator of gn is ignoring the arch passed when building the package.
Details
The changes involve adding arch flags to CFLAGS and LDFLAGS, allowing cross-compilation and universal binary support in macOS. They also include a change to allow passing the arch to other platforms, but the focus is on macOS.