Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cryptopp: Add use_openmp option #25419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

smessmer
Copy link

@smessmer smessmer commented Sep 26, 2024

This option is present in Crypto++'s CMakeList.txt but was not exposed in the conanfile.py. Adding exposure for it.

Summary

Changes to recipe: cryptopp/*

Motivation

This is an option that allows enabling OpenMP for the cryptographic algorithms in Crypto++. It will speed up some and slow down other algorithms.

Details

Default is False since it can have a negative performance impact on some algorithms. But it will speed up others, so it should be up to the caller.


This option is present in Crypto++'s CMakeList.txt but was not exposed in the conanfile.py. Adding exposure for it.
@CLAassistant
Copy link

CLAassistant commented Sep 26, 2024

CLA assistant check
All committers have signed the CLA.

@smessmer smessmer changed the title [cryptopp] Add use_openmp option cryptopp: Add use_openmp option Sep 26, 2024
@conan-center-bot

This comment has been minimized.

@smessmer smessmer mentioned this pull request Sep 26, 2024
@smessmer
Copy link
Author

No idea why ci fails. Asked for access in the access task because i thought that would allow me to read the CI logs, but even though I saw a task saying I supposedly have access now, I still can't read the CI log. Seems it's a pretty complicated process to try and contribute to conan. Not sure how to proceed.

@valgur
Copy link
Contributor

valgur commented Oct 1, 2024

Thanks! You will also need to list OpenMP in the package_info() linker flags for static builds to work for consumers.
See the code snippet in #24577 for an example, but skip cpp_info.cflags and cpp_info.cxxflags, since cryptopp does not appear to be using OpenMP in its public headers.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 5 (ed7a1f825bae2721c9138dab611400d90a39fca7):

  • cryptopp/8.9.0:
    Built 11 packages out of 22 (All logs)

  • cryptopp/8.8.0:
    Built 11 packages out of 22 (All logs)

  • cryptopp/8.6.0:
    All packages built successfully! (All logs)

  • cryptopp/8.7.0:
    Built 11 packages out of 22 (All logs)

  • cryptopp/8.2.0:
    All packages built successfully! (All logs)

  • cryptopp/8.5.0:
    All packages built successfully! (All logs)

  • cryptopp/8.4.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants