Remove Linter v2 migration #25329
Merged
Remove Linter v2 migration #25329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <uilianries@gmail.com>
AbrilRBS
approved these changes
Sep 19, 2024
|
🔥 |
danimtb
approved these changes
Sep 19, 2024
|
For future readers: #23757 (comment) |
ericLemanissier
added a commit
to ericLemanissier/conan-center-index
that referenced
this pull request
Sep 23, 2024
This reverts commit 5c32f2a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow-up PR #25323. After seeing the failure resulting of the previous PR, and discussing with Abril, and mainly, because there is a new linter under development to be used with Conan 2.x. I'm removing the migration v2 linter, as those rules are or mainly covered by Conan 2.x, or rarely occurs in CCI nowadays.
Details
Remove all files related to
.github/workflows/linter-conan-v2.yml. It may stop running the same linter in the CI.As mentioned before, Conan 2.x is mostly migrated, and those rules covered by the linter helped to avoid vicious of Conan 1.x when migrating recipes. It passed 19 months since 2.x release, so most of PRs are now following 2.x representation than trying to touch outdated elements of Conan 1.x
In the future, there will a new linter, focused to help reviewers and contributors, but focused in Conan 2.x