Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvpx: small recipe fix to support MSVC 19.40 aka 194 --> vs17 #24346

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

paulharris
Copy link
Contributor

Summary

Changes to recipe: libvpx/1.13.1 and 1.14.0

Motivation

New MSVC 19.40 is out, aka 194, and this recipe only considered 19.3x
This adds support by mapping 194 to vs17 (vs18 hasn't been released yet)

Details

One line change in recipe to add 193 to the version list.


@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (24520612e65cd44fa61f19ed32fb095b5e576939):

  • libvpx/1.14.0:
    All packages built successfully! (All logs)

  • libvpx/1.13.1:
    All packages built successfully! (All logs)

  • libvpx/1.10.0:
    All packages built successfully! (All logs)

  • libvpx/1.11.0:
    All packages built successfully! (All logs)

  • libvpx/1.9.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (24520612e65cd44fa61f19ed32fb095b5e576939):

  • libvpx/1.14.0:
    All packages built successfully! (All logs)

  • libvpx/1.9.0:
    All packages built successfully! (All logs)

  • libvpx/1.11.0:
    All packages built successfully! (All logs)

  • libvpx/1.10.0:
    All packages built successfully! (All logs)

  • libvpx/1.13.1:
    All packages built successfully! (All logs)

@AbrilRBS AbrilRBS self-assigned this Jun 16, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

There's a function inside Conan's internal API at conan/internal/api/detect_api.py that does pretty much this, I'll talk with the team to check if this is a recurring enough pattern and could be made public for recipes to use, not just the profile detectioon api

@conan-center-bot conan-center-bot merged commit 4e3c2ae into conan-io:master Jun 17, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants