-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tcpcat library publish #24062
tcpcat library publish #24062
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ydcpp thanks a lot for taking the time to submit your recipe, we appreciate it :)
I've taken the liberty to update the recipe with some improvements, and I've also left some comments - happy to hear your insight on those when you have a chance!
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@RubenRBS I updated upstream and library name, please check again. thanks in advance! |
@ydcpp oh my, I missed the ping from 20 days ago, I'm so sorry for the delay, will get to this tomorrow first thing in the morning :) |
Alas, I needed @uilianries to double check for me. The remaining failing in Conan 2 in Windows comes from the fact that no symbols are exported. Do you plan on supporting windows shared builds, or should we validate it out? |
hi @RubenRBS thanks for the reply, I also need some assistance for the build error on |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Hi @ydcpp sorry for the delay: We have now pushed the last fixes needed to get the recipe working. Note that as I explained in #24062 (comment), the current Windows shared builds have been disabled, as the current issue that no symbols are exported from your side in the library - let us know if you need any help with that, we can probably provide some hints as to how to better handle that on your side if needed :) Other than that, we can merge the recipe after the current build succeeds, will keep an eye on it to ensure it gets thru to the finish line quickly. Again, thanks for your patience and follow-ups in this process |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 8b5b463ydcpp-tcpcat/1.0.4@#3202abece933231c4dcd02c9d166ad06
|
This comment has been minimized.
This comment has been minimized.
deps.generate() | ||
tc = CMakeToolchain(self) | ||
if not self.settings.get_safe("compiler.cppstd"): | ||
tc.variables["CMAKE_CXX_STANDARD"] = self._min_cppstd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing something, because the project already does it: https://github.com/ydcpp/tcpcat/blob/1.0.4/CMakeLists.txt#L16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I actually didn't catch that - let's just try with your test package changes, see if that fixes everything :)
Conan v1 pipeline ✔️All green in build 17 (
Conan v2 pipeline ✔️
All green in build 17 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @ydcpp !!!
Specify library name and version: ydcpp-tcpcat/1.0.4
Hi,
I'm the author of tcpcat library. tcpcat is a simple and easy to use C++ TCP Client and Server library.
Just released the project and wanted to publish package also in conan center.
Thanks in advance!