Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librdkafka: fix link to openssl debug for msvc #24006

Merged
merged 1 commit into from
May 16, 2024
Merged

librdkafka: fix link to openssl debug for msvc #24006

merged 1 commit into from
May 16, 2024

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented May 15, 2024 •
edited
Loading

Do not rename openssl libs anymore if debug in rdkafka_ssl.c, since openssl recipe doesn't add d postfix anymore after #20999

closes #23988

@SpaceIm SpaceIm changed the title librdkafka: fix link to openssl debug on Windows librdkafka: fix link to openssl debug for msvc May 15, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (e69c2ca93fc5d3871c5c4f32a0e6f2b574ba2e23):

  • librdkafka/2.0.2:
    All packages built successfully! (All logs)

  • librdkafka/2.2.0:
    All packages built successfully! (All logs)

  • librdkafka/1.9.2:
    All packages built successfully! (All logs)

  • librdkafka/2.4.0:
    All packages built successfully! (All logs)

  • librdkafka/2.3.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (e69c2ca93fc5d3871c5c4f32a0e6f2b574ba2e23):

  • librdkafka/2.4.0:
    All packages built successfully! (All logs)

  • librdkafka/2.0.2:
    All packages built successfully! (All logs)

  • librdkafka/2.2.0:
    All packages built successfully! (All logs)

  • librdkafka/2.3.0:
    All packages built successfully! (All logs)

  • librdkafka/1.9.2:
    All packages built successfully! (All logs)

KevDi
KevDi approved these changes May 15, 2024
View reviewed changes
Copy link

@KevDi KevDi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

@AbrilRBS AbrilRBS self-assigned this May 16, 2024
uilianries
uilianries approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

librdkafka links the library using pragma: https://github.com/confluentinc/librdkafka/blob/v2.4.0/src/rdkafka_ssl.c#L44

This change follows the recent change involving OpenSSL and not renaming the library file when building in debug mode.

@conan-center-bot conan-center-bot merged commit 1e88c25 into conan-io:master May 16, 2024
34 checks passed
@SpaceIm SpaceIm deleted the fix/librdkafka-win-link-openssl-debug branch May 16, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@uilianries uilianries uilianries approved these changes

@ericLemanissier ericLemanissier ericLemanissier approved these changes

@KevDi KevDi KevDi approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[package] librdkafka/2.4.0: Unable to build in Debug Mode
6 participants
@SpaceIm @conan-center-bot @KevDi @ericLemanissier @uilianries @AbrilRBS