-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netpbm: new recipe #23402
base: master
Are you sure you want to change the base?
netpbm: new recipe #23402
Conversation
This comment has been minimized.
This comment has been minimized.
To match the VERSION file info installed with the package.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 12 (
Conan v2 pipeline ✔️
All green in build 12 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I want to know more in a few places, but besides that, it looks good :)
# Fix FILE not being defined in jpeglib.h | ||
replace_in_file(self, os.path.join(self.source_folder, "converter", "other", "cameratopam", "camera.c"), | ||
"#include <jpeglib.h>", "#include <stdio.h>\n#include <jpeglib.h>") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HAs this been reported upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, and the missing #include <stdio.h>
appears to be a bug in libjpeg, surprisingly enough. I'll have to investigate it a bit further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RubenRBS Indeed, libjpeg
itself is buggy. #23428
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. it's apparently by design for libjpeg. I'll try to submit a patch upstream for Netpbm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up on it, really appreciated! Let me know once this has been reported upstream :)
Adds Netpbm: https://netpbm.sourceforge.net/
Netpbm is a toolkit for manipulation of graphic images, including conversion of images between a variety of different formats. There are over 350 separate tools in the package including converters for about 100 graphics formats. Examples of the sort of image manipulation we're talking about are: Shrinking an image by 10%; Cutting the top half off of an image; Making a mirror image; Creating a sequence of images that fade from one image to another.