Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenVR: move to conan2, new version 2.2.3 #23021

Closed
wants to merge 1 commit into from

Conversation

AlexanderBabansky
Copy link

Specify library name and version: openvr/2.2.3

Ported to conan2, added new version, checked old version works too


@CLAassistant
Copy link

CLAassistant commented Mar 7, 2024

CLA assistant check
All committers have signed the CLA.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 1 (5cd80bc54eadae81cccf762cb01d94754947dd9a):

  • openvr/1.16.8:
    CI failed to create some packages (All logs)

    Logs for packageID 4d887c1c2779c63d2cdd81580698d2e22cb35b29:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=5
    os=Linux
    [options]
    openvr:shared=False
    
    [...]
    -----------------
    Scanning dependencies of target openvr_api
    [ 10%] Building CXX object src/CMakeFiles/openvr_api.dir/openvr_api_public.cpp.o
    [ 20%] Building CXX object src/CMakeFiles/openvr_api.dir/jsoncpp.cpp.o
    [ 30%] Building CXX object src/CMakeFiles/openvr_api.dir/vrcommon/dirtools_public.cpp.o
    [ 40%] Building CXX object src/CMakeFiles/openvr_api.dir/vrcommon/envvartools_public.cpp.o
    [ 50%] Building CXX object src/CMakeFiles/openvr_api.dir/vrcommon/pathtools_public.cpp.o
    [ 60%] Building CXX object src/CMakeFiles/openvr_api.dir/vrcommon/sharedlibtools_public.cpp.o
    [ 70%] Building CXX object src/CMakeFiles/openvr_api.dir/vrcommon/hmderrors_public.cpp.o
    [ 80%] Building CXX object src/CMakeFiles/openvr_api.dir/vrcommon/vrpathregistry_public.cpp.o
    [ 90%] Building CXX object src/CMakeFiles/openvr_api.dir/vrcommon/strtools_public.cpp.o
    [100%] Linking CXX static library /home/conan/w/prod-v1/bsr/117648/bdaee/.conan/data/openvr/1.16.8/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/src/bin/linux64/libopenvr_api.a
    [100%] Built target openvr_api
    openvr/1.16.8: Package '4d887c1c2779c63d2cdd81580698d2e22cb35b29' built
    openvr/1.16.8: Build folder /home/conan/w/prod-v1/bsr/117648/bdaee/.conan/data/openvr/1.16.8/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/build/Release
    openvr/1.16.8: Generated conaninfo.txt
    openvr/1.16.8: Generated conanbuildinfo.txt
    openvr/1.16.8: Generating the package
    openvr/1.16.8: Package folder /home/conan/w/prod-v1/bsr/117648/bdaee/.conan/data/openvr/1.16.8/_/_/package/4d887c1c2779c63d2cdd81580698d2e22cb35b29
    openvr/1.16.8: Calling package()
    openvr/1.16.8: Copied 1 file: LICENSE
    openvr/1.16.8: CMake command: cmake --install "/home/conan/w/prod-v1/bsr/117648/bdaee/.conan/data/openvr/1.16.8/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/build/Release" --prefix "/home/conan/w/prod-v1/bsr/117648/bdaee/.conan/data/openvr/1.16.8/_/_/package/4d887c1c2779c63d2cdd81580698d2e22cb35b29"
    
    ----Running------
    > cmake --install "/home/conan/w/prod-v1/bsr/117648/bdaee/.conan/data/openvr/1.16.8/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/build/Release" --prefix "/home/conan/w/prod-v1/bsr/117648/bdaee/.conan/data/openvr/1.16.8/_/_/package/4d887c1c2779c63d2cdd81580698d2e22cb35b29"
    -----------------
    -- Install configuration: "Release"
    -- Installing: /home/conan/w/prod-v1/bsr/117648/bdaee/.conan/data/openvr/1.16.8/_/_/package/4d887c1c2779c63d2cdd81580698d2e22cb35b29/lib/libopenvr_api.a
    -- Installing: /home/conan/w/prod-v1/bsr/117648/bdaee/.conan/data/openvr/1.16.8/_/_/package/4d887c1c2779c63d2cdd81580698d2e22cb35b29/include/openvr/openvr_driver.h
    -- Installing: /home/conan/w/prod-v1/bsr/117648/bdaee/.conan/data/openvr/1.16.8/_/_/package/4d887c1c2779c63d2cdd81580698d2e22cb35b29/include/openvr/openvr_capi.h
    -- Installing: /home/conan/w/prod-v1/bsr/117648/bdaee/.conan/data/openvr/1.16.8/_/_/package/4d887c1c2779c63d2cdd81580698d2e22cb35b29/include/openvr/openvr.h
    -- Installing: /home/conan/w/prod-v1/bsr/117648/bdaee/.conan/data/openvr/1.16.8/_/_/package/4d887c1c2779c63d2cdd81580698d2e22cb35b29/share/pkgconfig/openvr.pc
    [HOOK - conan-center.py] post_package(): [PACKAGE LICENSE (KB-H012)] OK
    [HOOK - conan-center.py] post_package(): [DEFAULT PACKAGE LAYOUT (KB-H013)] If you are trying to package a tool put all the contents under the 'bin' folder
    [HOOK - conan-center.py] post_package(): [MATCHING CONFIGURATION (KB-H014)] OK
    [HOOK - conan-center.py] post_package(): [SHARED ARTIFACTS (KB-H015)] OK
    [HOOK - conan-center.py] post_package(): [STATIC ARTIFACTS (KB-H074)] OK
    [HOOK - conan-center.py] post_package(): [EITHER STATIC OR SHARED OF EACH LIB (KB-H076)] OK
    [HOOK - conan-center.py] post_package(): [CMAKE-MODULES-CONFIG-FILES (KB-H016)] OK
    [HOOK - conan-center.py] post_package(): [PDB FILES NOT ALLOWED (KB-H017)] OK
    [HOOK - conan-center.py] post_package(): [LIBTOOL FILES PRESENCE (KB-H018)] OK
    [HOOK - conan-center.py] post_package(): [MS RUNTIME FILES (KB-H021)] OK
    [HOOK - conan-center.py] post_package(): [SHORT_PATHS USAGE (KB-H066)] OK
    [HOOK - conan-center.py] post_package(): [MISSING SYSTEM LIBS (KB-H043)] OK
    [HOOK - conan-center.py] post_package(): [APPLE RELOCATABLE SHARED LIBS (KB-H077)] OK
    openvr/1.16.8: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    [HOOK - conan-center.py] post_package(): ERROR: [DEFAULT PACKAGE LAYOUT (KB-H013)] Unknown folder 'share' in the package (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H013-DEFAULT-PACKAGE-LAYOUT) 
    [HOOK - conan-center.py] post_package(): ERROR: [PC-FILES (KB-H020)] The conan-center repository doesn't allow the packages to contain `pc` files. The packages have to be located using generators and the declared `cpp_info` information (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H020-PC-FILES) 
    [HOOK - conan-center.py] post_package(): ERROR: [PC-FILES (KB-H020)] Found files: ./share/pkgconfig/openvr.pc (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H020-PC-FILES) 
    ERROR: [HOOK - conan-center.py] post_package(): Some checks failed running the hook, check the output
    
  • openvr/1.14.15:
    Didn't run or was cancelled before finishing

  • openvr/2.2.3:
    Didn't run or was cancelled before finishing

  • openvr/1.12.5:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 1 (5cd80bc54eadae81cccf762cb01d94754947dd9a):

  • openvr/2.2.3:
    CI failed to create some packages (All logs)

    Logs for packageID 13be611585c95453f1cbbd053cea04b3e64470ca:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    [...]
    ======== Testing the package: Building ========
    openvr/2.2.3 (test package): Calling build()
    openvr/2.2.3 (test package): Running CMake.configure()
    openvr/2.2.3 (test package): RUN: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/w/prod-v2/bsr/cci-3fd3b222/recipes/openvr/all/test_package/build/gcc-11-x86_64-17-release/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/home/conan/w/prod-v2/bsr/cci-3fd3b222/recipes/openvr/all/test_package" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/conan/w/prod-v2/bsr/cci-3fd3b222/recipes/openvr/all/test_package"
    -- Using Conan toolchain: /home/conan/w/prod-v2/bsr/cci-3fd3b222/recipes/openvr/all/test_package/build/gcc-11-x86_64-17-release/generators/conan_toolchain.cmake
    -- Conan toolchain: C++ Standard 17 with extensions OFF
    -- The C compiler identification is GNU 11.1.0
    -- The CXX compiler identification is GNU 11.1.0
    -- Check for working C compiler: /usr/local/bin/cc
    -- Check for working C compiler: /usr/local/bin/cc -- works
    -- Detecting C compiler ABI info
    -- Detecting C compiler ABI info - done
    -- Detecting C compile features
    -- Detecting C compile features - done
    -- Check for working CXX compiler: /usr/local/bin/c++
    -- Check for working CXX compiler: /usr/local/bin/c++ -- works
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Conan: Target declared 'openvr::openvr'
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/conan/w/prod-v2/bsr/cci-3fd3b222/recipes/openvr/all/test_package/build/gcc-11-x86_64-17-release
    
    openvr/2.2.3 (test package): Running CMake.build()
    openvr/2.2.3 (test package): RUN: cmake --build "/home/conan/w/prod-v2/bsr/cci-3fd3b222/recipes/openvr/all/test_package/build/gcc-11-x86_64-17-release" -- -j3
    Scanning dependencies of target test_package
    [ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
    [100%] Linking CXX executable test_package
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/102547/cddef/p/b/openva9c1126853ac6/p/lib/libopenvr_api.a(pathtools_public.cpp.o): in function `Path_GetThisModulePath[abi:cxx11]()':
    pathtools_public.cpp:(.text+0x20): undefined reference to `dladdr'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/102547/cddef/p/b/openva9c1126853ac6/p/lib/libopenvr_api.a(sharedlibtools_public.cpp.o): in function `SharedLib_Load(char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*)':
    sharedlibtools_public.cpp:(.text+0x17): undefined reference to `dlopen'
    /opt/conan/binutils/bin/ld: sharedlibtools_public.cpp:(.text+0x41): undefined reference to `dlerror'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/102547/cddef/p/b/openva9c1126853ac6/p/lib/libopenvr_api.a(sharedlibtools_public.cpp.o): in function `SharedLib_GetFunction(void*, char const*)':
    sharedlibtools_public.cpp:(.text+0x1d1): undefined reference to `dlsym'
    /opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/bsr/102547/cddef/p/b/openva9c1126853ac6/p/lib/libopenvr_api.a(sharedlibtools_public.cpp.o): in function `SharedLib_Unload(void*)':
    sharedlibtools_public.cpp:(.text+0x1e6): undefined reference to `dlclose'
    collect2: error: ld returned 1 exit status
    CMakeFiles/test_package.dir/build.make:84: recipe for target 'test_package' failed
    make[2]: *** [test_package] Error 1
    CMakeFiles/Makefile2:75: recipe for target 'CMakeFiles/test_package.dir/all' failed
    make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
    Makefile:83: recipe for target 'all' failed
    make: *** [all] Error 2
    
    ERROR: openvr/2.2.3 (test package): Error in build() method, line 20
    	cmake.build()
    	ConanException: Error 2 while executing
    
  • openvr/1.16.8:
    Didn't run or was cancelled before finishing

  • openvr/1.12.5:
    Didn't run or was cancelled before finishing

  • openvr/1.14.15:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@ghost
Copy link

ghost commented Mar 7, 2024

I detected other pull requests that are modifying openvr/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@AbrilRBS
Copy link
Member

Hi! Thanks a lot for taking the time to port this library to v2. After checking, it seems like there's an old PR that already ports this recipe. Could you check if #18788 works for you too? It's already working, so we can focus on merging both works into one :)

@AbrilRBS
Copy link
Member

Closing as the linked PR has now been merged, thanks a lot for taking the time to contribute this nevertheless, really appreciated :)

@AbrilRBS AbrilRBS closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants