-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libudev: Set the pkg-config version to the real version number #23013
libudev: Set the pkg-config version to the real version number #23013
Conversation
The pkg-config file contains the version of the Conan package. This is problematic because it is `system` which causes version checks for libudev to fail. This happens in Weston I'm making for instance: ``` Dependency libudev found: NO found system but need: '>= 136' Found CMake: /usr/local/bin/cmake (3.28.20240202) Run-time dependency libudev found: NO (tried cmake) ../src/libweston/meson.build:196:2: ERROR: Dependency lookup for libudev with method 'pkgconfig' failed: Invalid version, need 'libudev' ['>= 136'] found 'system'. ``` I've set the version in the pkg-config file to that of the version on the system. This fixes version checks in consumers using pkg-config.
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 (
|
Hello @jwillikers Could you please share your entire build log? Please, try to follow the bug package template when sending hotfix without an issue associate, so we can reproduce your error quickly, without asking for extra information. |
@uilianries This currently effects two unmerged PR's: #20358 and #22938. To reproduce the one for libweston, which I placed above, you'd need to build multiple dependencies which haven't been merged like Mesa and PipeWire, and there'd be a lot of dependency version conflicts getting in the way as well. The build logs I've included contain all the pertinent information for the error. It's probably easier to look at the code here to understand what is happening: dependencies: [
dep_libweston_private,
dep_libinput,
dependency('libudev', version: '>= 136')
], The |
@jwillikers Thank your for the details, now I see your scenario! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The follow-up clarifies this fix.
The pkg-config file contains the version of the Conan package. This is problematic because it is
system
which causes version checks for libudev to fail. This happens in Weston I'm making for instance:I've set the version in the pkg-config file to that of the version on the system. This fixes version checks in consumers using pkg-config.