-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[boost] Hotfix: Detect cxxstd flag correctly #22817
[boost] Hotfix: Detect cxxstd flag correctly #22817
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
🤖 Beep Boop! This pull request is making changes to 'recipes/boost//'. 👋 @grafikrobot @Hopobcn @jwillikers you might be interested. 😉 |
Building locally with Conan 2.1.x + GCC 9 + compiler.cppstd=20 I have:
The C++ standard is now configured according to the supported one: |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit b25c1edboost/1.84.0@#9a9d6e165f21952b557661246b1d6a24
boost/1.82.0@#e19ac860535a801198a28935ec9aec53
boost/1.83.0@#c1583ac5e0da5e20957978c9d530c4c9
boost/1.81.0@#6e280fd4a10c2d4ca20242585463127c
boost/1.80.0@#188f8eb9d5d9416768db77a3f753f40f
boost/1.78.0@#2dd682c61f52d1b8a4afcb1e1cb5a8d0
boost/1.79.0@#4be52b91916f82940791873e5a5d606b
boost/1.76.0@#2632fbd314abdd99e770de3187fde8c9
boost/1.77.0@#27320e1381813b04d0396dca7bd06c77
boost/1.74.0@#5bd60c1b6d3d35c543aed07755806ba0
boost/1.71.0@#3e7155b18ff4cc2acdf59d8bb7d21765
boost/1.75.0@#73687439adf2162d6cc4ccc52a32d41e
boost/1.73.0@#89fc371df20e7ae024e72aaa89f71178
boost/1.72.0@#b67856c860e97220c5d336e1d083e9cb
|
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline ✔️
All green in build 3 (
|
Hooks produced the following warnings for commit d64852dboost/1.84.0@#774abb4a1b3702b2f7171ac6b6de777a
boost/1.80.0@#67fc7512612c159e8de20c62f16933f7
boost/1.83.0@#731379b0ea691088ae33ead4dde0fcde
boost/1.75.0@#749e61c501b0cf1a0f398537e93c81f1
boost/1.72.0@#51b09c90038262c631a8e649c499819d
boost/1.77.0@#8322f603bb09c033a92f8173da2d83ca
boost/1.82.0@#1f0d64e495afad4c45daa9a7b37cf6e1
boost/1.81.0@#21f2c671219d474104b5e55e09cd40ff
boost/1.79.0@#e845120ded7c398d77f28f921cbe4595
boost/1.78.0@#3fff16107b4228ca97ba95da527337e9
boost/1.74.0@#94aafb00c68554773a588c5c0494bbf9
boost/1.73.0@#4812bd5e1b544788a5a28bc0f8b9c1ce
boost/1.76.0@#c250ccd4756fa45a559a74a1a090d857
boost/1.71.0@#cad563cd3ea638ddf60bc76ccddcddaa
|
In Conan 1.x is possible to know the C++ standard flag used by the compiler when having the cppstd declared: https://docs.conan.io/1/reference/tools.html#tools-cppstd-flag
However, we don't have that tool ported to Conan 2.x (yet): conan-io/conan#12603
Plus, there is no such B2 toolchain class supported yet, so we need to dig to find the correct flags that will be passed to b2. The B2 project has its own parameter for stdcpp, the
cxxstd
: https://www.boost.org/doc/libs/1_84_0/tools/build/doc/html/index.html#bbv2.builtin.features.cxxstd. So, we need to pass without any prefix.This PR partially copies the implementation available in https://github.com/conan-io/conan/blob/develop2/conan/tools/build/flags.py to pass the supported C++ standard flag.
fixes #22816