-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxWidgets intial recipe #21353
wxWidgets intial recipe #21353
Conversation
…e; ported from bincrafters to v2
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
This comment has been minimized.
This comment has been minimized.
So I'm not sure if this will be solved anytime soon. |
This comment has been minimized.
This comment has been minimized.
Hi @gmeeker, |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 7 (
Conan v2 pipeline ✔️
All green in build 7 (
|
Why is there ninja in build requirements? Putting ninja in build requirement of a recipe doesn't mean that it will be used as CMake generator. It would also require to force |
if self.options.get_safe("secretstore"): | ||
packages.append("libsecret-1-dev") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is libsecret in conancenter.
I'm surprised by this recipe. I thought it was forbidden to have system requirements explicitly requested in conancenter recipes (except for a "system" recipe).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question. How did this get past hook checks and human reviews?
Specify library name and version: wxwidgets/3.2.3
Implements #5190 #19991 #20092
Requested by #621
This is a new recipe to CCI. It's an updated version from bincrafters but ported to Conan v2 with additional fixes.
https://github.com/bincrafters/community/tree/main/recipes/wxwidgets
Also unmerged GTK3 work from here (using GTK from Conan recipe):
bincrafters/community#1434
GTK support is currently a draft but macOS and Windows seem usable. Any feedback appreciated. For example, do we need anything older than 3.2.3 here?