Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdfium: migrate to Conan v2 #21130

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Nov 14, 2023

Bumped the version to the newest one supported by pdfium-cmake.
The existing version had compilation issues in its C++17 compatibility library.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 2539f2c
pdfium/95.0.4629@#e4cfa125138f4f91dffc93d0d44a9d23
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libpdfium.dylib' links to system library 'AppKit' but it is not in cpp_info.frameworks.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (81b298161911451a9ea4aa8b10ce84ef5b73b3ae):

  • pdfium/95.0.4629:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (81b298161911451a9ea4aa8b10ce84ef5b73b3ae):

  • pdfium/95.0.4629:
    All packages built successfully! (All logs)

@AbrilRBS AbrilRBS self-assigned this Nov 15, 2023
"Visual Studio": 15,
"gcc": "8",
"msvc": "191",
"Visual Studio": "15",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no restriction on clang, is the package not compatible with it (Seems like it is based on build logs) or just missing info?

Copy link
Contributor Author

@valgur valgur Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It built fine with Clang 5.0 in Docker. Conan 2 itself failed to install in the old Clang 4.0 container. I guess leaving it unspecified is ok.

@conan-center-bot conan-center-bot merged commit 461b261 into conan-io:master Nov 15, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants