Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update corrade recipe #2111

Merged
merged 10 commits into from
Jul 6, 2020
Merged

Update corrade recipe #2111

merged 10 commits into from
Jul 6, 2020

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented Jul 2, 2020

Specify library name and version: corrade/all

closes #1397

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'corrade/2019.10' failed in build 1 (a24c33576613db0b918b99626fe5bb24fbee8886):

  • Linux x86_64, Release, gcc 5, libstdc++ . Options: corrade:shared-True
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CMAKE VERBOSE MAKEFILE (KB-H046)] The CMake definition 'set(CMAKE_VERBOSE_MAKEFILE ON)' is not allowed. Remove it from recipes/corrade/all/test_package/CMakeLists.txt. (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H046)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@conan-center-bot
Copy link
Collaborator

Some configurations of 'corrade/2019.10' failed in build 2 (756c82e2cd9303525cb50fcbb56c22b3c9c540d2):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'corrade/2019.10' failed in build 3 (5c828fa42e9c34090e0e270ede05f8151f3b7e8a):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'corrade/2019.10' failed in build 4 (1e86bb245c3ee4a03ae2f2c850af4fd452173470):

@conan-center-bot
Copy link
Collaborator

All green in build 5 (b501b759ffb2e2b1b344a73addf4b0bf1252bc62)! 😊

@conan-center-bot
Copy link
Collaborator

All green in build 6 (ff233d905ea55919f622a2a91ef336b8369f03cb)! 😊

uilianries
uilianries previously approved these changes Jul 2, 2020
@uilianries uilianries requested review from jgsogo and SSE4 July 2, 2020 19:48
recipes/corrade/all/conanfile.py Outdated Show resolved Hide resolved
recipes/corrade/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

All green in build 7 (16b4a8f6ecabe2612fb8ac68e3f898af7dee55ea)! 😊

@conan-center-bot
Copy link
Collaborator

Failure in build 8 (2b5953cfce46f784ea400cfae86267bb57a5c8d6):
corrade/2019.10:

  • Error processing recipe: Macos x86_64, Debug, apple-clang 9.1, libc++ . Options: corrade:shared-True
    Unexpected error happened:
corrade/2019.10: WARN: THIS IS CROSS-BUILDING!
ERROR: corrade/2019.10: Error in configure() method, line 53
	raise ConanException("This Corrade recipe doesn't support cross building yet")
	ConanException: This Corrade recipe doesn't support cross building yet

@danimtb
Copy link
Member Author

danimtb commented Jul 3, 2020

So the problem here was clearly on the tools.cross_building() and the ConanInvalidConfiguration.

As part of the pipeline, we iterate the recipe with conan info for all the profiles we are using and checking if the package ID is the same for some of them in order to discard any build that is not needed. However, this process is done in a Linux machine and it detects that using a Windows or Macos profile, you are cross-building. Finally ConanInvalidConfiguration prevents the pipeline from raising, as it is considered an expected error.

I have removed the exception there and left a warning just in case.

@conan-center-bot
Copy link
Collaborator

All green in build 9 (c7b1e3ff30635c300535a422675634955952fdab)! 😊

@danimtb danimtb requested a review from uilianries July 3, 2020 09:11
@danimtb danimtb requested a review from jgsogo July 3, 2020 09:11
@Croydon
Copy link
Contributor

Croydon commented Jul 3, 2020

So the problem here was clearly on the tools.cross_building() and the ConanInvalidConfiguration.

As part of the pipeline, we iterate the recipe with conan info for all the profiles we are using and checking if the package ID is the same for some of them in order to discard any build that is not needed. However, this process is done in a Linux machine and it detects that using a Windows or Linux profile, you are cross-building. FInally ConanInvalidConfiguration prevents the pipeline from raising, as it is considered an expected error.

I have removed the exception there and left a warning just in case.

Thanks for figuring this one out!

Sounds like something which could happen more often as this is an implementation detail which isn't really on the mind of recipe authors 🤔

@Croydon Croydon mentioned this pull request Jul 3, 2020
@conan-center-bot
Copy link
Collaborator

All green in build 10 (3589795e5095a7cd3424004c450df933de18e529)! 😊

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SSE4 SSE4 merged commit d1b554f into conan-io:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[service] corrade/2019.10 has only Linux builds and most are outdated
6 participants