Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userver: add unspecified version #20712

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

userver: add unspecified version #20712

wants to merge 2 commits into from

Conversation

xakod
Copy link
Contributor

@xakod xakod commented Oct 20, 2023

Specify library name and version: userver/cci.20231018

I understand recipe looks like a bit bloated and test package too, but both of them require a lot of thirdparty libraries and specific options so it's nontrivial task.

@conan-center-bot conan-center-bot added Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Oct 20, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added Version conflict There is a version conflict when solving the dependencies graph and removed Missing dependencies Build failed due missing dependencies in Conan Center labels Oct 20, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Oct 20, 2023
@conan-center-bot

This comment has been minimized.

@xakod
Copy link
Contributor Author

xakod commented Oct 20, 2023

Waiting for #19971 in order to resolve version conflict.

@AbrilRBS
Copy link
Member

Retriggered again, linked PR has now been merged

@AbrilRBS AbrilRBS self-assigned this Oct 23, 2023
@AbrilRBS AbrilRBS removed Missing dependencies Build failed due missing dependencies in Conan Center Version conflict There is a version conflict when solving the dependencies graph labels Oct 23, 2023
@conan-center-bot conan-center-bot added Missing dependencies Build failed due missing dependencies in Conan Center Version conflict There is a version conflict when solving the dependencies graph labels Oct 23, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@xakod
Copy link
Contributor Author

xakod commented Oct 24, 2023

Waiting for #20091

@xakod
Copy link
Contributor Author

xakod commented Oct 24, 2023

@RubenRBS is there any way to build mogo-c-driver with_sasl=cyrus?

@AbrilRBS
Copy link
Member

@RubenRBS is there any way to build mogo-c-driver with_sasl=cyrus?

@Jihadist for cci no, it's not currently possible to build configurations other than the defaul ones defined in the recipe - this is something we're currently looking into allowing, but for now checks should be made in the validate method to ensure that the expected options have been activated by the user. This means that no binaries will be made for that configuration, so please do provide local logs of your builds when testing them, as it makes reviewing and future maintenance way easier :)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @Jihadist - we really appreciate it.

This is a first review (Thanks for your patience while I got around to it!), and I have some comments and suggestions. My biggest doubt right now is about the need for a non default option on the dependency, which right now generates no binaries here, happy to discuss it further

recipes/userver/all/conanfile.py Show resolved Hide resolved
recipes/userver/all/conanfile.py Show resolved Hide resolved
recipes/userver/all/conanfile.py Outdated Show resolved Hide resolved
recipes/userver/all/conanfile.py Show resolved Hide resolved
recipes/userver/all/conanfile.py Show resolved Hide resolved
recipes/userver/all/conanfile.py Outdated Show resolved Hide resolved
recipes/userver/all/conanfile.py Outdated Show resolved Hide resolved
@AbrilRBS AbrilRBS removed the Missing dependencies Build failed due missing dependencies in Conan Center label Oct 26, 2023
@conan-center-bot

This comment has been minimized.

@xakod xakod closed this Nov 2, 2023
@xakod xakod reopened this Nov 2, 2023
@conan-center-bot conan-center-bot removed the Version conflict There is a version conflict when solving the dependencies graph label Nov 2, 2023
@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

Hi! Thanks for the ping, sorry that this one got lost among the rest of PRs: Note that opening and closing PRs makes Github Projects set the status to "Done", which we don't often check, so it's easier that the PR gets delayed if you do that :)

if you ever need to rebuild, pressing the "Update branch" button usually works best!

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, after going again thru this, it looks mostly good, but I'll ask someone else from the team to check a few extra things tomororw, sorry for such a long delay, thanks a lot for your patience :)

default_options = {
'fPIC': True,
'lto': True,
'with_jemalloc': False, # Disabled dy default due to jemalloc recipe does not support Conan v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jemalloc is now available in Conan 2, feel free to make this True by default if upstream following https://github.com/userver-framework/userver/blob/13ca039791f9dbaa9da36e3e55e86451516dfa7f/CMakeLists.txt#L96 :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know but I fixed this recipe so many tries that now I have no desire to do it again

@xakod
Copy link
Contributor Author

xakod commented Apr 16, 2024

Hi! Thanks for the ping, sorry that this one got lost among the rest of PRs: Note that opening and closing PRs makes Github Projects set the status to "Done", which we don't often check, so it's easier that the PR gets delayed if you do that :)

if you ever need to rebuild, pressing the "Update branch" button usually works best!

Oh, now I understand why my other prs have been waiting review for months

@xakod
Copy link
Contributor Author

xakod commented Sep 17, 2024

@AbrilRBS sorry for ping but looks like no one review this. Should I close it?

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2024

CLA assistant check
All committers have signed the CLA.

@AbrilRBS
Copy link
Member

AbrilRBS commented Oct 5, 2024

Hi @xakod, the issue here is that the CLA has not yet been signed, thus we can not begind the process to get this into CCI. We'd need that all emails sign the CLA. If you commited under a different email, the best thing to do would be to squash all commits under your main account. How does that sound?

@xakod
Copy link
Contributor Author

xakod commented Oct 7, 2024

@AbrilRBS you have been ignored this pr from April :)

xakod added 2 commits October 7, 2024 20:29
bump deps

review fixes

disable mongo, optional conan tests

compilers_minimum_version

fix pytest

move scripts inside lib

fix include dirs

fix std for test package

Update CMakeLists.txt

option for testsuite

Update conanfile.py

Try to disable everything

disable utest too

Another attempt to fix and update

Update config.yml

Update CMakeLists.txt

Fix testsuite test

Update conanfile.py

disable DWCAS

Update conanfile.py

another attempt to disable dwcas
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

Failure in build 2 (0e4a8286d5205d29cf7b0e5285264df1eda49029):

  • userver/cci.20240219:
    CI failed to create some packages (All logs)

    Logs for packageID d8f57b86b628c8981c03bc3fed1fba16c77c9cd8:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=9
    os=Linux
    
    [...]
    -- Conan: Component target declared 'libnghttp2::nghttp2'
    -- Conan: Target declared 'libnghttp2::libnghttp2'
    -- Conan: Component target declared 'CURL::libcurl'
    -- Conan: Component target declared 'OpenSSL::Crypto'
    -- Conan: Component target declared 'OpenSSL::SSL'
    -- Conan: Target declared 'openssl::openssl'
    -- Conan: Including build module from '/home/conan/workspace/prod-v1/bsr/110828/fbfac/.conan/data/openssl/3.3.2/_/_/package/3b92fb92d86b5880d7fcd3124cd3e37e04f7e25f/lib/cmake/conan-official-openssl-variables.cmake'
    -- Conan: Component target declared 'cryptopp::cryptopp'
    -- Conan: Component target declared 'c-ares::cares'
    -- Conan: Target declared 'rapidjson'
    -- Conan: Including build module from '/home/conan/workspace/prod-v1/bsr/110828/fbfac/.conan/data/userver/cci.20240219/_/_/package/d8f57b86b628c8981c03bc3fed1fba16c77c9cd8/lib/cmake/conan_helper.cmake'
    -- Found Python: /opt/pyenv/versions/3.7.17/bin/python3.7 (found version "3.7.17") found components: Interpreter Development Development.Module Development.Embed 
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /home/conan/workspace/prod-v1/bsr/cci-9a99ef67/recipes/userver/all/test_package/build/Release
    userver/cci.20240219 (test package): CMake command: cmake --build "/home/conan/workspace/prod-v1/bsr/cci-9a99ef67/recipes/userver/all/test_package/build/Release" '--' '-j3'
    
    ----Running------
    > cmake --build "/home/conan/workspace/prod-v1/bsr/cci-9a99ef67/recipes/userver/all/test_package/build/Release" '--' '-j3'
    -----------------
    Scanning dependencies of target PackageTest_objs
    [ 20%] Building CXX object CMakeFiles/PackageTest_objs.dir/hello.cpp.o
    [ 20%] Built target PackageTest_objs
    Scanning dependencies of target PackageTest_universal
    [ 40%] Building CXX object CMakeFiles/PackageTest_universal.dir/test_universal.cpp.o
    Scanning dependencies of target PackageTest_core
    [ 60%] Building CXX object CMakeFiles/PackageTest_core.dir/test_core.cpp.o
    [ 80%] Linking CXX executable PackageTest_universal
    [100%] Linking CXX executable PackageTest_core
    [100%] Built target PackageTest_universal
    [100%] Built target PackageTest_core
    userver/cci.20240219 (test package): Running test()
    
    ----Running------
    > . "/home/conan/workspace/prod-v1/bsr/cci-9a99ef67/recipes/userver/all/test_package/build/Release/generators/conanrun.sh" && ./PackageTest_core
    -----------------
    15
    WARN: **************************************************
    WARN: *** Conan 1 is legacy and on a deprecation path **
    WARN: *********** Please upgrade to Conan 2 ************
    WARN: **************************************************
    WARN: boost/1.79.0: requirement zlib/[>=1.2.11 <2] overridden by userver/cci.20240219 to zlib/1.3.1 
    WARN: libcurl/7.88.1: requirement openssl/[>=1.1 <4] overridden by userver/cci.20240219 to openssl/3.3.2 
    WARN: libcurl/7.88.1: requirement zlib/[>=1.2.11 <2] overridden by userver/cci.20240219 to zlib/1.3.1 
    WARN: openssl/3.3.2: requirement zlib/[>=1.2.11 <2] overridden by libcurl/7.88.1 to zlib/1.3.1 
    userver/cci.20240219 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    userver/cci.20240219 (test package): WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    ERROR: userver/cci.20240219 (test package): Error in test() method, line 32
    	if self.dependencies[self.tested_reference_str].options.with_utest:
    	AttributeError: 'NoneType' object has no attribute 'dependencies'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (0e4a8286d5205d29cf7b0e5285264df1eda49029):

  • userver/cci.20240219:
    Built 2 packages out of 10 (All logs)

Copy link
Contributor

Hooks produced the following warnings for commit 0e4a828
userver/cci.20240219@#778ffbba5410f4380729522e6d28ca26
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] The *.cmake files have to be placed in a folder declared as `cpp_info.builddirs`. Currently folders declared: {'/home/conan/workspace/prod-v1/bsr/110828/fbfac/.conan/data/userver/cci.20240219/_/_/package/d8f57b86b628c8981c03bc3fed1fba16c77c9cd8/'}
post_package_info(): WARN: [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] Found files: ./lib/cmake/conan_helper.cmake

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 30, 2024
@AbrilRBS AbrilRBS removed their assignment Dec 4, 2024
@github-actions github-actions bot removed the stale label Dec 5, 2024
Copy link
Contributor

github-actions bot commented Jan 5, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants