Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmslib: fix missing glibc symbols on newer systems #20273

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Oct 2, 2023

Related to conan-io/hooks#508
Applying the hook temporarily as a part of the package to validate that the fix for the glibc issue works.

A full list of packages affected by removed glibc symbols can be found here:
https://gist.github.com/valgur/4fec44c680d3df6401495dc8be4642d2

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Oct 10, 2023

I detected other pull requests that are modifying nmslib/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur valgur marked this pull request as ready for review October 12, 2023 12:23
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (698317ef28ca01b4d1b0e4a817971923c93edcbe):

  • nmslib/2.1.1:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (698317ef28ca01b4d1b0e4a817971923c93edcbe):

  • nmslib/2.1.1:
    All packages built successfully! (All logs)

@valgur
Copy link
Contributor Author

valgur commented Oct 12, 2023

The fix for the glibc issue works and the PR is ready to be merged.

@AbrilRBS AbrilRBS self-assigned this Oct 17, 2023
@conan-center-bot conan-center-bot merged commit d1bd12a into conan-io:master Oct 18, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants